Re: [PATCH v2 net-next 1/7] tcp: do not assume TCP code is non preemptible

2016-04-29 Thread Soheil Hassas Yeganeh
On Fri, Apr 29, 2016 at 10:37 AM, Eric Dumazet wrote: > On Fri, 2016-04-29 at 09:18 -0400, Soheil Hassas Yeganeh wrote: >> On Thu, Apr 28, 2016 at 11:10 PM, Eric Dumazet wrote: > >> > + NET_ADD_STATS(sock_net(sk), >> > + >

Re: [PATCH v2 net-next 1/7] tcp: do not assume TCP code is non preemptible

2016-04-29 Thread Eric Dumazet
On Fri, 2016-04-29 at 09:18 -0400, Soheil Hassas Yeganeh wrote: > On Thu, Apr 28, 2016 at 11:10 PM, Eric Dumazet wrote: > > + NET_ADD_STATS(sock_net(sk), > > + LINUX_MIB_TCPHYSTARTTRAINCWND, > > +

Re: [PATCH v2 net-next 1/7] tcp: do not assume TCP code is non preemptible

2016-04-29 Thread Soheil Hassas Yeganeh
On Thu, Apr 28, 2016 at 11:10 PM, Eric Dumazet wrote: > We want to to make TCP stack preemptible, as draining prequeue > and backlog queues can take lot of time. > > Many SNMP updates were assuming that BH (and preemption) was disabled. > > Need to convert some __NET_INC_STATS() calls to NET_INC_S

[PATCH v2 net-next 1/7] tcp: do not assume TCP code is non preemptible

2016-04-28 Thread Eric Dumazet
We want to to make TCP stack preemptible, as draining prequeue and backlog queues can take lot of time. Many SNMP updates were assuming that BH (and preemption) was disabled. Need to convert some __NET_INC_STATS() calls to NET_INC_STATS() and some __TCP_INC_STATS() to TCP_INC_STATS() Before usin