Re: [PATCH v2 net-next 09/10] net: Remove unused get_hash_from_flow functions

2018-03-02 Thread David Ahern
On 3/2/18 7:09 AM, Ido Schimmel wrote: >> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c >> index 559db9ea8d86..d29f09bc5ff9 100644 >> --- a/net/core/flow_dissector.c >> +++ b/net/core/flow_dissector.c >> @@ -1341,22 +1341,6 @@ __u32 __get_hash_from_flowi6(const struct flowi6 >

Re: [PATCH v2 net-next 09/10] net: Remove unused get_hash_from_flow functions

2018-03-02 Thread Ido Schimmel
On Thu, Mar 01, 2018 at 07:29:49PM -0800, David Ahern wrote: > __get_hash_from_flowi6 is still used for flowlabels, but the IPv4 > variant and the wrappers to both are not used. Remove them. > > Signed-off-by: David Ahern Reviewed-by: Ido Schimmel One nit below. > --- > include/net/flow.h

[PATCH v2 net-next 09/10] net: Remove unused get_hash_from_flow functions

2018-03-01 Thread David Ahern
__get_hash_from_flowi6 is still used for flowlabels, but the IPv4 variant and the wrappers to both are not used. Remove them. Signed-off-by: David Ahern --- include/net/flow.h| 15 --- net/core/flow_dissector.c | 16 2 files changed, 31 deletions(-) diff --g