Re: [PATCH v2 net-next 07/12] ionic: reduce contiguous memory allocation requirement

2020-08-27 Thread Shannon Nelson
On 8/27/20 2:25 PM, Jakub Kicinski wrote: On Thu, 27 Aug 2020 12:53:17 -0700 Shannon Nelson wrote: On 8/27/20 12:46 PM, Jakub Kicinski wrote: On Thu, 27 Aug 2020 11:07:30 -0700 Shannon Nelson wrote: + q_base = (void *)PTR_ALIGN((uintptr_t)new->q_base, PAGE_SIZE); The point of PTR_ALIGN

Re: [PATCH v2 net-next 07/12] ionic: reduce contiguous memory allocation requirement

2020-08-27 Thread Jakub Kicinski
On Thu, 27 Aug 2020 12:53:17 -0700 Shannon Nelson wrote: > On 8/27/20 12:46 PM, Jakub Kicinski wrote: > > On Thu, 27 Aug 2020 11:07:30 -0700 Shannon Nelson wrote: > >> + q_base = (void *)PTR_ALIGN((uintptr_t)new->q_base, PAGE_SIZE); > > The point of PTR_ALIGN is to make the casts unnecessary.

Re: [PATCH v2 net-next 07/12] ionic: reduce contiguous memory allocation requirement

2020-08-27 Thread Shannon Nelson
On 8/27/20 12:46 PM, Jakub Kicinski wrote: On Thu, 27 Aug 2020 11:07:30 -0700 Shannon Nelson wrote: + q_base = (void *)PTR_ALIGN((uintptr_t)new->q_base, PAGE_SIZE); The point of PTR_ALIGN is to make the casts unnecessary. Does it not work? Here's what I see from two different compiler

Re: [PATCH v2 net-next 07/12] ionic: reduce contiguous memory allocation requirement

2020-08-27 Thread Jakub Kicinski
On Thu, 27 Aug 2020 11:07:30 -0700 Shannon Nelson wrote: > Authored-by: Neel Patel Also - what's Authored-by? :S Do we need a sign-off for this? Perhaps Co-developed-by, which is more standard?

Re: [PATCH v2 net-next 07/12] ionic: reduce contiguous memory allocation requirement

2020-08-27 Thread Jakub Kicinski
On Thu, 27 Aug 2020 11:07:30 -0700 Shannon Nelson wrote: > + q_base = (void *)PTR_ALIGN((uintptr_t)new->q_base, PAGE_SIZE); The point of PTR_ALIGN is to make the casts unnecessary. Does it not work?

[PATCH v2 net-next 07/12] ionic: reduce contiguous memory allocation requirement

2020-08-27 Thread Shannon Nelson
Split out the queue descriptor blocks into separate dma allocations to make for smaller blocks. Authored-by: Neel Patel Signed-off-by: Shannon Nelson --- .../ethernet/pensando/ionic/ionic_debugfs.c | 23 ++-- .../net/ethernet/pensando/ionic/ionic_lif.c | 100 +++--- .../net/eth