Re: [PATCH v2 net-next 03/10] net: dsa: add ops for devlink-sb

2021-01-08 Thread Vladimir Oltean
On Fri, Jan 08, 2021 at 12:35:23AM +0100, Andrew Lunn wrote: > > +static struct dsa_port *devlink_to_dsa_port(struct devlink_port *dlp) > > +{ > > + return container_of(dlp, struct dsa_port, devlink_port); > > +} > > I wonder if this should be moved to include/net/dsa.h next to the > other littl

Re: [PATCH v2 net-next 03/10] net: dsa: add ops for devlink-sb

2021-01-07 Thread Andrew Lunn
> +static struct dsa_port *devlink_to_dsa_port(struct devlink_port *dlp) > +{ > + return container_of(dlp, struct dsa_port, devlink_port); > +} I wonder if this should be moved to include/net/dsa.h next to the other little helpers used to convert between devlink structures and DSA structures?

[PATCH v2 net-next 03/10] net: dsa: add ops for devlink-sb

2021-01-07 Thread Vladimir Oltean
From: Vladimir Oltean Switches that care about QoS might have hardware support for reserving buffer pools for individual ports or traffic classes, and configuring their sizes and thresholds. Through devlink-sb (shared buffers), this is all configurable, as well as their occupancy being viewable.