Re: [PATCH v2 net-next 00/12] net: stmmac: Clean-up and tune-up

2018-05-18 Thread Jose Abreu
Hi David, On 17-05-2018 19:47, David Miller wrote: > From: David Miller > Date: Thu, 17 May 2018 14:41:17 -0400 (EDT) > >> From: Jose Abreu >> Date: Thu, 17 May 2018 14:24:42 +0100 >> >>> Given that the difference between better/worst is < 1%, I think >>> we can conclude patches 3-13 don't affec

Re: [PATCH v2 net-next 00/12] net: stmmac: Clean-up and tune-up

2018-05-17 Thread David Miller
From: David Miller Date: Thu, 17 May 2018 14:41:17 -0400 (EDT) > From: Jose Abreu > Date: Thu, 17 May 2018 14:24:42 +0100 > >> Given that the difference between better/worst is < 1%, I think >> we can conclude patches 3-13 don't affect the overall >> performance. I didn't profile the cache hits

Re: [PATCH v2 net-next 00/12] net: stmmac: Clean-up and tune-up

2018-05-17 Thread David Miller
From: Jose Abreu Date: Thu, 17 May 2018 14:24:42 +0100 > Given that the difference between better/worst is < 1%, I think > we can conclude patches 3-13 don't affect the overall > performance. I didn't profile the cache hits/miss though ... Ok, thanks for making an effort to look into this more t

Re: [PATCH v2 net-next 00/12] net: stmmac: Clean-up and tune-up

2018-05-17 Thread Jose Abreu
Hi David, Florian, Results of slowing down CPU follows bellow. On 16-05-2018 20:01, Florian Fainelli wrote: > On 05/16/2018 11:56 AM, David Miller wrote: >> From: Jose Abreu >> Date: Wed, 16 May 2018 13:50:42 +0100 >> >>> David raised some rightfull constrains about the use of indirect callbacks

Re: [PATCH v2 net-next 00/12] net: stmmac: Clean-up and tune-up

2018-05-16 Thread Florian Fainelli
On 05/16/2018 11:56 AM, David Miller wrote: > From: Jose Abreu > Date: Wed, 16 May 2018 13:50:42 +0100 > >> David raised some rightfull constrains about the use of indirect callbacks in >> the code. I did iperf tests with and without patches 3-12 and the performance >> remained equal. I guess for

Re: [PATCH v2 net-next 00/12] net: stmmac: Clean-up and tune-up

2018-05-16 Thread David Miller
From: Jose Abreu Date: Wed, 16 May 2018 13:50:42 +0100 > David raised some rightfull constrains about the use of indirect callbacks in > the code. I did iperf tests with and without patches 3-12 and the performance > remained equal. I guess for 1Gb/s and because my setup has a powerfull > process

[PATCH v2 net-next 00/12] net: stmmac: Clean-up and tune-up

2018-05-16 Thread Jose Abreu
This targets to uniformize the handling of the different GMAC versions in stmmac_main.c file and also tune-up the HW. Currently there are some if/else conditions in the main source file which calls different callbacks depending on the ID of GMAC. With the introducion of a generic HW interface han