Re: [PATCH v2 net-next] veth: Free queues on link delete

2018-08-14 Thread Toshiaki Makita
On 2018/08/15 10:29, David Ahern wrote: > On 8/14/18 7:16 PM, Toshiaki Makita wrote: >> Hmm, on second thought this queues need to be freed after veth_close() >> to make sure no packet will reference them. That means we need to free >> them in .ndo_uninit() or destructor. >> (rtnl_delete_link() cal

Re: [PATCH v2 net-next] veth: Free queues on link delete

2018-08-14 Thread David Ahern
On 8/14/18 7:16 PM, Toshiaki Makita wrote: > Hmm, on second thought this queues need to be freed after veth_close() > to make sure no packet will reference them. That means we need to free > them in .ndo_uninit() or destructor. > (rtnl_delete_link() calls dellink() before unregister_netdevice_many(

Re: [PATCH v2 net-next] veth: Free queues on link delete

2018-08-14 Thread Toshiaki Makita
On 2018/08/15 10:04, dsah...@kernel.org wrote: > From: David Ahern > > kmemleak reported new suspected memory leaks. > $ cat /sys/kernel/debug/kmemleak > unreferenced object 0x8800354d5c00 (size 1024): > comm "ip", pid 836, jiffies 4294722952 (age 25.904s) > hex dump (first 32 bytes): >

[PATCH v2 net-next] veth: Free queues on link delete

2018-08-14 Thread dsahern
From: David Ahern kmemleak reported new suspected memory leaks. $ cat /sys/kernel/debug/kmemleak unreferenced object 0x8800354d5c00 (size 1024): comm "ip", pid 836, jiffies 4294722952 (age 25.904s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ...