Re: [PATCH v2 net-next] net: metrics: add proper netlink validation

2018-06-05 Thread David Miller
From: Eric Dumazet Date: Tue, 5 Jun 2018 06:06:19 -0700 > Before using nla_get_u32(), better make sure the attribute > is of the proper size. > > Code recently was changed, but bug has been there from beginning > of git. ... > Fixes: a919525ad832 ("net: Move fib_convert_metrics to metrics file

[PATCH v2 net-next] net: metrics: add proper netlink validation

2018-06-05 Thread Eric Dumazet
Before using nla_get_u32(), better make sure the attribute is of the proper size. Code recently was changed, but bug has been there from beginning of git. BUG: KMSAN: uninit-value in rtnetlink_put_metrics+0x553/0x960 net/core/rtnetlink.c:746 CPU: 1 PID: 14139 Comm: syz-executor6 Not tainted 4.17