Re: [PATCH v2 net-next] net: ipv4: Consider unreachable nexthops in multipath routes

2016-04-01 Thread David Ahern
On 4/1/16 2:09 AM, Julian Anastasov wrote: diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c index d97268e8ff10..6d423faff0ce 100644 --- a/net/ipv4/fib_semantics.c +++ b/net/ipv4/fib_semantics.c @@ -1559,17 +1559,45 @@ int fib_sync_up(struct net_device *dev, unsigned int nh_flags)

Re: [PATCH v2 net-next] net: ipv4: Consider unreachable nexthops in multipath routes

2016-04-01 Thread Julian Anastasov
Hello, On Thu, 31 Mar 2016, David Ahern wrote: > To maintain backward compatibility use of the neighbor information is > based on a new sysctl, fib_multipath_use_neigh. > > Signed-off-by: David Ahern > --- > v2 > - use rcu locking to avoid refcnts per Eric's suggestion > - only conside

[PATCH v2 net-next] net: ipv4: Consider unreachable nexthops in multipath routes

2016-03-31 Thread David Ahern
Multipath route lookups should consider knowledge about next hops and not select a hop that is known to be failed. Example: [h2] [h3] 15.0.0.5 | | 3| 3|