Re: [PATCH v2 net-next] ixgbe: Avoid unaligned access in ixgbe_atr() for LLC packets

2016-03-14 Thread Sowmini Varadhan
On (03/14/16 12:20), Alexander Duyck wrote: > I figure it is better to just drop it since we don't need to be trying > to parse ARP packets anyway. Ok, let me send out v3.

Re: [PATCH v2 net-next] ixgbe: Avoid unaligned access in ixgbe_atr() for LLC packets

2016-03-14 Thread Alexander Duyck
On Mon, Mar 14, 2016 at 10:59 AM, Sowmini Varadhan wrote: > On (03/14/16 10:55), Alexander Duyck wrote: >> >> One other thing I forgot to mention is that we don't support ARP so >> that check could be dropped. The ATR code only supports IPv4 or IPv6 >> with TCP. > > I did notice that, but I left

[PATCH v2 net-next] ixgbe: Avoid unaligned access in ixgbe_atr() for LLC packets

2016-03-14 Thread Sowmini Varadhan
For LLC based protocols like lldp, stp etc., the ethernet header is an 802.3 header with a h_proto that is not 0x800, 0x86dd, or even 0x806. In this world, the skb_network_header() points at the DSAP/SSAP/.. and is not likely to be NET_IP_ALIGNed in ixgbe_atr(). With LLC, drivers are not likely

Re: [PATCH v2 net-next] ixgbe: Avoid unaligned access in ixgbe_atr() for LLC packets

2016-03-14 Thread Sowmini Varadhan
On (03/14/16 10:55), Alexander Duyck wrote: > > One other thing I forgot to mention is that we don't support ARP so > that check could be dropped. The ATR code only supports IPv4 or IPv6 > with TCP. I did notice that, but I left it in place because (a) it comes down the stack with the NET_IP_ALI

Re: [PATCH v2 net-next] ixgbe: Avoid unaligned access in ixgbe_atr() for LLC packets

2016-03-14 Thread Alexander Duyck
On Mon, Mar 14, 2016 at 10:46 AM, Sowmini Varadhan wrote: > > For LLC based protocols like lldp, stp etc., the ethernet header > is an 802.3 header with a h_proto that is not 0x800, 0x86dd, or > even 0x806. In this world, the skb_network_header() points at > the DSAP/SSAP/.. and is not likely to