Re: [PATCH v2 net-next] cxgb4: remove bogus CHELSIO_VPD_UNIQUE_ID constant

2021-01-21 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 20 Jan 2021 08:27:14 +0100 you wrote: > The comment is quite weird, there is no such thing as a vendor-specific > VPD id. 0x82 is the value of PCI_VPD_LRDT_ID_STRING. So what we are > doing here is simply checking w

[PATCH v2 net-next] cxgb4: remove bogus CHELSIO_VPD_UNIQUE_ID constant

2021-01-19 Thread Heiner Kallweit
The comment is quite weird, there is no such thing as a vendor-specific VPD id. 0x82 is the value of PCI_VPD_LRDT_ID_STRING. So what we are doing here is simply checking whether the byte at VPD address VPD_BASE is a valid string LRDT, same as what is done a few lines later in the code. LRDT = Large