Re: [PATCH v2 net] net: qed: fix buffer overflow on ethtool -d

2020-07-07 Thread David Miller
From: Alexander Lobakin Date: Mon, 6 Jul 2020 12:25:53 +0300 > When generating debug dump, driver firstly collects all data in binary > form, and then performs per-feature formatting to human-readable if it > is supported. > > For ethtool -d, this is roughly incorrect for two reasons. First of a

[PATCH v2 net] net: qed: fix buffer overflow on ethtool -d

2020-07-06 Thread Alexander Lobakin
When generating debug dump, driver firstly collects all data in binary form, and then performs per-feature formatting to human-readable if it is supported. For ethtool -d, this is roughly incorrect for two reasons. First of all, drivers should always provide only original raw dumps to Ethtool with