Re: [PATCH v2 net] net/tls: fix encryption error checking

2020-05-19 Thread Vadim Fedorenko
On 20.05.2020 02:10, Jakub Kicinski wrote: On Wed, 20 May 2020 01:49:33 +0300 Vadim Fedorenko wrote: On 20.05.2020 01:04, Jakub Kicinski wrote: On Tue, 19 May 2020 13:20:43 +0300 Vadim Fedorenko wrote: bpf_exec_tx_verdict() can return negative value for copied variable. In that case this value

Re: [PATCH v2 net] net/tls: fix encryption error checking

2020-05-19 Thread Jakub Kicinski
On Wed, 20 May 2020 01:49:33 +0300 Vadim Fedorenko wrote: > On 20.05.2020 01:04, Jakub Kicinski wrote: > > On Tue, 19 May 2020 13:20:43 +0300 Vadim Fedorenko wrote: > >> bpf_exec_tx_verdict() can return negative value for copied > >> variable. In that case this value will be pushed back to caller

Re: [PATCH v2 net] net/tls: fix encryption error checking

2020-05-19 Thread Vadim Fedorenko
On 20.05.2020 01:04, Jakub Kicinski wrote: On Tue, 19 May 2020 13:20:43 +0300 Vadim Fedorenko wrote: bpf_exec_tx_verdict() can return negative value for copied variable. In that case this value will be pushed back to caller and the real error code will be lost. Fix it using signed type and check

Re: [PATCH v2 net] net/tls: fix encryption error checking

2020-05-19 Thread Jakub Kicinski
On Tue, 19 May 2020 13:20:43 +0300 Vadim Fedorenko wrote: > bpf_exec_tx_verdict() can return negative value for copied > variable. In that case this value will be pushed back to caller > and the real error code will be lost. Fix it using signed type and > checking for positive value. > > Fixes: d1

[PATCH v2 net] net/tls: fix encryption error checking

2020-05-19 Thread Vadim Fedorenko
bpf_exec_tx_verdict() can return negative value for copied variable. In that case this value will be pushed back to caller and the real error code will be lost. Fix it using signed type and checking for positive value. Fixes: d10523d0b3d7 ("net/tls: free the record on encryption error") Fixes: d3b