RE: [PATCH v2 net] lan743x: Fix RX Kernel Panic

2019-03-11 Thread Bryan.Whitehead
> Applied and queued up for -stable, thanks. Thanks David

Re: [PATCH v2 net] lan743x: Fix RX Kernel Panic

2019-03-11 Thread David Miller
From: David Miller Date: Mon, 11 Mar 2019 12:18:12 -0700 (PDT) > From: > Date: Mon, 11 Mar 2019 18:50:27 + > >> In this case the function lan743x_rx_init_ring_element does not assume that >> new_skb is not NULL. It does check for NULL and returns error in that case. > > Aha, I see, thanks

Re: [PATCH v2 net] lan743x: Fix RX Kernel Panic

2019-03-11 Thread David Miller
From: Date: Mon, 11 Mar 2019 18:50:27 + > In this case the function lan743x_rx_init_ring_element does not assume that > new_skb is not NULL. It does check for NULL and returns error in that case. Aha, I see, thanks for pointing that out and correcting me. Let me review this some more.

RE: [PATCH v2 net] lan743x: Fix RX Kernel Panic

2019-03-11 Thread Bryan.Whitehead
> -Original Message- > From: David Miller > Sent: Monday, March 11, 2019 2:37 PM > To: Bryan Whitehead - C21958 > Cc: netdev@vger.kernel.org; UNGLinuxDriver > > Subject: Re: [PATCH v2 net] lan743x: Fix RX Kernel Panic > > From: Bryan Whitehead > Date: M

Re: [PATCH v2 net] lan743x: Fix RX Kernel Panic

2019-03-11 Thread David Miller
From: Bryan Whitehead Date: Mon, 11 Mar 2019 13:39:39 -0400 > @@ -2290,7 +2306,9 @@ static int lan743x_rx_ring_init(struct lan743x_rx *rx) > > rx->last_head = 0; > for (index = 0; index < rx->ring_size; index++) { > - ret = lan743x_rx_allocate_ring_element(rx, index); >

[PATCH v2 net] lan743x: Fix RX Kernel Panic

2019-03-11 Thread Bryan Whitehead
It has been noticed that running the speed test at www.speedtest.net occasionally causes a kernel panic. Investigation revealed that under this test RX buffer allocation sometimes fails and returns NULL. But the lan743x driver did not handle this case. This patch fixes this issue by attempting to