Re: [PATCH v2 net] ixgbe: fix parsing of TC actions for HW offload

2018-05-31 Thread David Miller
From: Jeff Kirsher Date: Thu, 31 May 2018 14:46:08 -0700 > On Thu, 2018-05-31 at 23:21 +0200, Ondřej Hlavatý wrote: >> The previous code was optimistic, accepting the offload of whole >> action >> chain when there was a single known action (drop/redirect). This >> results >> in offloading a rule

Re: [PATCH v2 net] ixgbe: fix parsing of TC actions for HW offload

2018-05-31 Thread Jeff Kirsher
On Thu, 2018-05-31 at 23:21 +0200, Ondřej Hlavatý wrote: > The previous code was optimistic, accepting the offload of whole > action > chain when there was a single known action (drop/redirect). This > results > in offloading a rule which should not be offloaded, because its > behavior > cannot be

[PATCH v2 net] ixgbe: fix parsing of TC actions for HW offload

2018-05-31 Thread Ondřej Hlavatý
The previous code was optimistic, accepting the offload of whole action chain when there was a single known action (drop/redirect). This results in offloading a rule which should not be offloaded, because its behavior cannot be reproduced in the hardware. For example: $ tc filter add dev eno1 par