Re: [PATCH v2 net] ip6_tunnel: set inner ipproto before ip6_tnl_encap

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 20:10:12 +0300 Alexander Ovechkin wrote: > ip6_tnl_encap assigns to proto transport protocol which > encapsulates inner packet, but we must pass to set_inner_ipproto > protocol of that inner packet. > > Calling set_inner_ipproto after ip6_tnl_encap might break gso. > For exampl

[PATCH v2 net] ip6_tunnel: set inner ipproto before ip6_tnl_encap

2020-10-29 Thread Alexander Ovechkin
ip6_tnl_encap assigns to proto transport protocol which encapsulates inner packet, but we must pass to set_inner_ipproto protocol of that inner packet. Calling set_inner_ipproto after ip6_tnl_encap might break gso. For example, in case of encapsulating ipv6 packet in fou6 packet, inner_ipproto wo