Re: [PATCH v2 net] gre: fix error handler

2016-06-16 Thread Eric Dumazet
On Thu, 2016-06-16 at 09:40 +0200, Jiri Benc wrote: > Reviewed-by: Jiri Benc > > I know this has already been applied. Didn't get to it earlier, sorry. > The patch looks good. Thanks! Thanks Jiri for reviewing it !

Re: [PATCH v2 net] gre: fix error handler

2016-06-16 Thread Jiri Benc
On Wed, 15 Jun 2016 06:24:00 -0700, Eric Dumazet wrote: > From: Eric Dumazet > > 1) gre_parse_header() can be called from gre_err() > >At this point transport header points to ICMP header, not the inner > header. > > 2) We can not really change transport header as ipgre_err() will later > a

Re: [PATCH v2 net] gre: fix error handler

2016-06-15 Thread David Miller
From: Eric Dumazet Date: Wed, 15 Jun 2016 06:24:00 -0700 > From: Eric Dumazet > > 1) gre_parse_header() can be called from gre_err() > >At this point transport header points to ICMP header, not the inner > header. > > 2) We can not really change transport header as ipgre_err() will later

[PATCH v2 net] gre: fix error handler

2016-06-15 Thread Eric Dumazet
From: Eric Dumazet 1) gre_parse_header() can be called from gre_err() At this point transport header points to ICMP header, not the inner header. 2) We can not really change transport header as ipgre_err() will later assume transport header still points to ICMP header (using icmp_hdr()) 3)