Re: [PATCH v2 net] bonding: prevent out of bound accesses

2016-07-01 Thread David Miller
From: Eric Dumazet Date: Thu, 30 Jun 2016 16:13:41 +0200 > From: Eric Dumazet > > ether_addr_equal_64bits() requires some care about its arguments, > namely that 8 bytes might be read, even if last 2 byte values are not > used. > > KASan detected a violation with null_mac_addr and lacpdu_mcast

Re: [PATCH v2 net] bonding: prevent out of bound accesses

2016-06-30 Thread Ding Tianhong
On 2016/6/30 22:13, Eric Dumazet wrote: > From: Eric Dumazet > > ether_addr_equal_64bits() requires some care about its arguments, > namely that 8 bytes might be read, even if last 2 byte values are not > used. > > KASan detected a violation with null_mac_addr and lacpdu_mcast_addr > in bond_3ad

Re: [PATCH v2 net] bonding: prevent out of bound accesses

2016-06-30 Thread Nikolay Aleksandrov
On 30/06/16 16:13, Eric Dumazet wrote: > From: Eric Dumazet > > ether_addr_equal_64bits() requires some care about its arguments, > namely that 8 bytes might be read, even if last 2 byte values are not > used. > > KASan detected a violation with null_mac_addr and lacpdu_mcast_addr > in bond_3ad.

Re: [PATCH v2 net] bonding: prevent out of bound accesses

2016-06-30 Thread Dmitry Vyukov
On Thu, Jun 30, 2016 at 4:13 PM, Eric Dumazet wrote: > From: Eric Dumazet > > ether_addr_equal_64bits() requires some care about its arguments, > namely that 8 bytes might be read, even if last 2 byte values are not > used. > > KASan detected a violation with null_mac_addr and lacpdu_mcast_addr >

[PATCH v2 net] bonding: prevent out of bound accesses

2016-06-30 Thread Eric Dumazet
From: Eric Dumazet ether_addr_equal_64bits() requires some care about its arguments, namely that 8 bytes might be read, even if last 2 byte values are not used. KASan detected a violation with null_mac_addr and lacpdu_mcast_addr in bond_3ad.c Same problem with mac_bcast[] and mac_v6_allmcast[]