Re: [PATCH v2 iproute2] lib: Dump ext-ack string by default

2017-08-09 Thread David Ahern
On 8/9/17 1:38 AM, Girish Moodalbail wrote: >> @@ -99,7 +95,16 @@ static int nl_dump_ext_err(const struct nlmsghdr >> *nlh, nl_ext_ack_fn_t errfn) >> err_nlh = &err->msg; >> } >> -return errfn(errmsg, off, err_nlh); >> +if (errfn) >> +return errfn(errmsg, off,

Re: [PATCH v2 iproute2] lib: Dump ext-ack string by default

2017-08-09 Thread Girish Moodalbail
On 8/8/17 7:30 AM, David Ahern wrote: In time, errfn can be implemented for link, route, etc commands to give a much more detailed response (e.g., point to the attribute that failed). Doing so is much more complicated to process the message and convert attribute ids to names. In any case the err

[PATCH v2 iproute2] lib: Dump ext-ack string by default

2017-08-08 Thread David Ahern
In time, errfn can be implemented for link, route, etc commands to give a much more detailed response (e.g., point to the attribute that failed). Doing so is much more complicated to process the message and convert attribute ids to names. In any case the error string returned by the kernel should