Re: [PATCH v2 bpf-next 3/4] bpf: Allow using bpf_sk_storage in FENTRY/FEXIT/RAW_TP

2020-11-16 Thread Martin KaFai Lau
On Mon, Nov 16, 2020 at 10:43:40AM -0800, Jakub Kicinski wrote: > On Mon, 16 Nov 2020 10:37:49 -0800 Martin KaFai Lau wrote: > > On Mon, Nov 16, 2020 at 10:00:04AM -0800, Jakub Kicinski wrote: > > > Locks that can run in any context but preempt disabled or softirq > > > disabled? > > Not exactly.

Re: [PATCH v2 bpf-next 3/4] bpf: Allow using bpf_sk_storage in FENTRY/FEXIT/RAW_TP

2020-11-16 Thread Jakub Kicinski
On Mon, 16 Nov 2020 10:37:49 -0800 Martin KaFai Lau wrote: > On Mon, Nov 16, 2020 at 10:00:04AM -0800, Jakub Kicinski wrote: > > Locks that can run in any context but preempt disabled or softirq > > disabled? > Not exactly. e.g. running from irq won't work. > > > Let me cut to the chase. Are you

Re: [PATCH v2 bpf-next 3/4] bpf: Allow using bpf_sk_storage in FENTRY/FEXIT/RAW_TP

2020-11-16 Thread Martin KaFai Lau
On Mon, Nov 16, 2020 at 10:00:04AM -0800, Jakub Kicinski wrote: > On Mon, 16 Nov 2020 09:37:34 -0800 Martin KaFai Lau wrote: > > On Sat, Nov 14, 2020 at 05:17:20PM -0800, Jakub Kicinski wrote: > > > On Thu, 12 Nov 2020 13:13:13 -0800 Martin KaFai Lau wrote: > > > > This patch adds bpf_sk_storage_

Re: [PATCH v2 bpf-next 3/4] bpf: Allow using bpf_sk_storage in FENTRY/FEXIT/RAW_TP

2020-11-16 Thread Jakub Kicinski
On Mon, 16 Nov 2020 10:00:04 -0800 Jakub Kicinski wrote: > irq_count() Umpf. I meant (in_irq() || in_nmi()), don't care about sirq.

Re: [PATCH v2 bpf-next 3/4] bpf: Allow using bpf_sk_storage in FENTRY/FEXIT/RAW_TP

2020-11-16 Thread Jakub Kicinski
On Mon, 16 Nov 2020 09:37:34 -0800 Martin KaFai Lau wrote: > On Sat, Nov 14, 2020 at 05:17:20PM -0800, Jakub Kicinski wrote: > > On Thu, 12 Nov 2020 13:13:13 -0800 Martin KaFai Lau wrote: > > > This patch adds bpf_sk_storage_get_tracing_proto and > > > bpf_sk_storage_delete_tracing_proto. They w

Re: [PATCH v2 bpf-next 3/4] bpf: Allow using bpf_sk_storage in FENTRY/FEXIT/RAW_TP

2020-11-16 Thread Martin KaFai Lau
On Sat, Nov 14, 2020 at 05:17:20PM -0800, Jakub Kicinski wrote: > On Thu, 12 Nov 2020 13:13:13 -0800 Martin KaFai Lau wrote: > > This patch adds bpf_sk_storage_get_tracing_proto and > > bpf_sk_storage_delete_tracing_proto. They will check > > in runtime that the helpers can only be called when ser

Re: [PATCH v2 bpf-next 3/4] bpf: Allow using bpf_sk_storage in FENTRY/FEXIT/RAW_TP

2020-11-14 Thread Jakub Kicinski
On Thu, 12 Nov 2020 13:13:13 -0800 Martin KaFai Lau wrote: > This patch adds bpf_sk_storage_get_tracing_proto and > bpf_sk_storage_delete_tracing_proto. They will check > in runtime that the helpers can only be called when serving > softirq or running in a task context. That should enable > most

[PATCH v2 bpf-next 3/4] bpf: Allow using bpf_sk_storage in FENTRY/FEXIT/RAW_TP

2020-11-12 Thread Martin KaFai Lau
This patch enables the FENTRY/FEXIT/RAW_TP tracing program to use the bpf_sk_storage_(get|delete) helper, so those tracing programs can access the sk's bpf_local_storage and the later selftest will show some examples. The bpf_sk_storage is currently used in bpf-tcp-cc, tc, cg sockops...etc which i