Re: [PATCH v2 bpf-next 0/3] fix BTF verification size resolution

2019-07-12 Thread Daniel Borkmann
On 07/12/2019 05:42 PM, Andrii Nakryiko wrote: > On Fri, Jul 12, 2019 at 5:59 AM Daniel Borkmann wrote: >> On 07/12/2019 08:03 AM, Yonghong Song wrote: >>> On 7/10/19 11:53 PM, Andrii Nakryiko wrote: BTF size resolution logic isn't always resolving type size correctly, leading to e

Re: [PATCH v2 bpf-next 0/3] fix BTF verification size resolution

2019-07-12 Thread Andrii Nakryiko
On Fri, Jul 12, 2019 at 5:59 AM Daniel Borkmann wrote: > > On 07/12/2019 08:03 AM, Yonghong Song wrote: > > On 7/10/19 11:53 PM, Andrii Nakryiko wrote: > >> BTF size resolution logic isn't always resolving type size correctly, > >> leading > >> to erroneous map creation failures due to value size

Re: [PATCH v2 bpf-next 0/3] fix BTF verification size resolution

2019-07-12 Thread Daniel Borkmann
On 07/12/2019 08:03 AM, Yonghong Song wrote: > On 7/10/19 11:53 PM, Andrii Nakryiko wrote: >> BTF size resolution logic isn't always resolving type size correctly, leading >> to erroneous map creation failures due to value size mismatch. >> >> This patch set: >> 1. fixes the issue (patch #1); >> 2.

Re: [PATCH v2 bpf-next 0/3] fix BTF verification size resolution

2019-07-11 Thread Yonghong Song
On 7/10/19 11:53 PM, Andrii Nakryiko wrote: > BTF size resolution logic isn't always resolving type size correctly, leading > to erroneous map creation failures due to value size mismatch. > > This patch set: > 1. fixes the issue (patch #1); > 2. adds tests for trickier cases (patch #2); > 3. an

[PATCH v2 bpf-next 0/3] fix BTF verification size resolution

2019-07-10 Thread Andrii Nakryiko
BTF size resolution logic isn't always resolving type size correctly, leading to erroneous map creation failures due to value size mismatch. This patch set: 1. fixes the issue (patch #1); 2. adds tests for trickier cases (patch #2); 3. and converts few test cases utilizing BTF-defined maps, that p