Re: [PATCH v2 bpf-next] bpf: fix bpf_iter's task iterator logic

On Wed, May 13, 2020 at 10:54 PM Andrii Nakryiko wrote: > > task_seq_get_next might stop prematurely if get_pid_task() fails to get > task_struct. Failure to do so doesn't mean that there are no more tasks with > higher pids. Procfs's iteration algorithm (see next_tgid in fs/proc/base.c) > does a

[PATCH v2 bpf-next] bpf: fix bpf_iter's task iterator logic

task_seq_get_next might stop prematurely if get_pid_task() fails to get task_struct. Failure to do so doesn't mean that there are no more tasks with higher pids. Procfs's iteration algorithm (see next_tgid in fs/proc/base.c) does a retry in such case. After this fix, instead of stopping prematurely