Re: [PATCH v2 bpf] bpf: devmap: fix wrong interface selection in notifier_call

2018-10-25 Thread Daniel Borkmann
On 10/24/2018 01:15 PM, Taehee Yoo wrote: > The dev_map_notification() removes interface in devmap if > unregistering interface's ifindex is same. > But only checking ifindex is not enough because other netns can have > same ifindex. so that wrong interface selection could occurred. > Hence netdev

Re: [PATCH v2 bpf] bpf: devmap: fix wrong interface selection in notifier_call

2018-10-24 Thread Song Liu
On Wed, Oct 24, 2018 at 4:16 AM Taehee Yoo wrote: > > The dev_map_notification() removes interface in devmap if > unregistering interface's ifindex is same. > But only checking ifindex is not enough because other netns can have > same ifindex. so that wrong interface selection could occurred. > He

[PATCH v2 bpf] bpf: devmap: fix wrong interface selection in notifier_call

2018-10-24 Thread Taehee Yoo
The dev_map_notification() removes interface in devmap if unregistering interface's ifindex is same. But only checking ifindex is not enough because other netns can have same ifindex. so that wrong interface selection could occurred. Hence netdev pointer comparison code is added. v2: compare netde