Re: [PATCH v2 3/8] net: macb: add function to disable all macb clocks

2020-12-09 Thread kernel test robot
Hi Claudiu, I love your patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on net-next/master net/master linus/master v5.10-rc7 next-20201208] [cannot apply to sparc-next/master] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH v2 3/8] net: macb: add function to disable all macb clocks

2020-12-08 Thread Florian Fainelli
On 12/7/20 4:15 AM, Claudiu Beznea wrote: > Add function to disable all macb clocks. > > Signed-off-by: Claudiu Beznea > Suggested-by: Andrew Lunn > --- > drivers/net/ethernet/cadence/macb_main.c | 62 > > 1 file changed, 32 insertions(+), 30 deletions(-) > >

Re: [PATCH v2 3/8] net: macb: add function to disable all macb clocks

2020-12-08 Thread Jakub Kicinski
On Tue, 8 Dec 2020 19:48:56 +0100 Andrew Lunn wrote: > > -err_disable_rxclk: > > - clk_disable_unprepare(*rx_clk); > > - > > -err_disable_txclk: > > - clk_disable_unprepare(*tx_clk); > > - > > -err_disable_hclk: > > - clk_disable_unprepare(*hclk); > > - > > -err_disable_pclk: > > - clk_disa

Re: [PATCH v2 3/8] net: macb: add function to disable all macb clocks

2020-12-08 Thread Andrew Lunn
Hi Claudiu > static int macb_clk_init(struct platform_device *pdev, struct clk **pclk, >struct clk **hclk, struct clk **tx_clk, >struct clk **rx_clk, struct clk **tsu_clk) > @@ -3743,40 +3753,37 @@ static int macb_clk_init(struct platform_device >

[PATCH v2 3/8] net: macb: add function to disable all macb clocks

2020-12-07 Thread Claudiu Beznea
Add function to disable all macb clocks. Signed-off-by: Claudiu Beznea Suggested-by: Andrew Lunn --- drivers/net/ethernet/cadence/macb_main.c | 62 1 file changed, 32 insertions(+), 30 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/driver