Re: [PATCH v2 2/5] spi: spi-fsl-dspi: Exit the ISR with IRQ_NONE when it's not ours

2019-08-23 Thread Vladimir Oltean
Hi Mark, On Fri, 23 Aug 2019 at 13:59, Mark Brown wrote: > > On Fri, Aug 23, 2019 at 11:50:44AM +0100, Mark Brown wrote: > > On Fri, Aug 23, 2019 at 01:30:27PM +0300, Vladimir Oltean wrote: > > > > Did you see this? > > > https://lkml.org/lkml/2019/8/22/1542 > > > I'm not online enough to readily

Re: [PATCH v2 2/5] spi: spi-fsl-dspi: Exit the ISR with IRQ_NONE when it's not ours

2019-08-23 Thread Mark Brown
On Fri, Aug 23, 2019 at 11:50:44AM +0100, Mark Brown wrote: > On Fri, Aug 23, 2019 at 01:30:27PM +0300, Vladimir Oltean wrote: > > Did you see this? > > https://lkml.org/lkml/2019/8/22/1542 > I'm not online enough to readily follow that link right now, I > did apply another patch for a similar is

Re: [PATCH v2 2/5] spi: spi-fsl-dspi: Exit the ISR with IRQ_NONE when it's not ours

2019-08-23 Thread Mark Brown
On Fri, Aug 23, 2019 at 01:30:27PM +0300, Vladimir Oltean wrote: > On Fri, 23 Aug 2019 at 13:28, Mark Brown wrote: > > It would be better to have done this as the first patch before > > the restructuring, that way we could send this as a fix - the > > refactoring while good doesn't really fit wit

Re: [PATCH v2 2/5] spi: spi-fsl-dspi: Exit the ISR with IRQ_NONE when it's not ours

2019-08-23 Thread Vladimir Oltean
Hi Mark, On Fri, 23 Aug 2019 at 13:28, Mark Brown wrote: > > On Fri, Aug 23, 2019 at 12:15:11AM +0300, Vladimir Oltean wrote: > > The DSPI interrupt can be shared between two controllers at least on the > > LX2160A. In that case, the driver for one controller might misbehave and > > consume the o

Re: [PATCH v2 2/5] spi: spi-fsl-dspi: Exit the ISR with IRQ_NONE when it's not ours

2019-08-23 Thread Mark Brown
On Fri, Aug 23, 2019 at 12:15:11AM +0300, Vladimir Oltean wrote: > The DSPI interrupt can be shared between two controllers at least on the > LX2160A. In that case, the driver for one controller might misbehave and > consume the other's interrupt. Fix this by actually checking if any of > the bits