Re: [PATCH v2 2/4] arp: decompose is_garp logic into a separate function

2017-05-24 Thread Ihar Hrachyshka
On 05/18/2017 01:49 PM, Julian Anastasov wrote: All 4 patches look ok to me with only a small problem which comes from patch already included in kernel. I see that GARP replies can not work for 1394, is_garp will be cleared. May be 'tha' check should be moved in if expression, for exampl

Re: [PATCH v2 2/4] arp: decompose is_garp logic into a separate function

2017-05-18 Thread Julian Anastasov
Hello, On Thu, 18 May 2017, Ihar Hrachyshka wrote: > The code is quite involving already to earn a separate function for > itself. If anything, it helps arp_process readability. > > Signed-off-by: Ihar Hrachyshka > --- > net/ipv4/arp.c | 35 +++ > 1 fil

[PATCH v2 2/4] arp: decompose is_garp logic into a separate function

2017-05-18 Thread Ihar Hrachyshka
The code is quite involving already to earn a separate function for itself. If anything, it helps arp_process readability. Signed-off-by: Ihar Hrachyshka --- net/ipv4/arp.c | 35 +++ 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a/net/ipv4/arp.c b/