Re: [PATCH v2 1/4] net: macb: Check MDIO state before read/write and use timeouts

2018-11-29 Thread Claudiu.Beznea
On 28.11.2018 02:35, Andrew Lunn wrote: >> Then, do you think it would be better to have a new API part of struct >> mii_bus that drivers should register so that, the mii core to check if the >> bus is idle before lunching a new request? > > I'm not sure that actually brings anything useful. Th

Re: [PATCH v2 1/4] net: macb: Check MDIO state before read/write and use timeouts

2018-11-27 Thread Andrew Lunn
> Then, do you think it would be better to have a new API part of struct > mii_bus that drivers should register so that, the mii core to check if the > bus is idle before lunching a new request? I'm not sure that actually brings anything useful. The core does not benefit from it, and it does not

Re: [PATCH v2 1/4] net: macb: Check MDIO state before read/write and use timeouts

2018-11-27 Thread Harini Katakam
Hi Claudiu, > > Replace the while loop in MDIO read/write functions with a timeout. > In addition, add a check for MDIO bus busy before initiating a new > operation as well to make sure there is no ongoing MDIO operation. > >>> > >>> Is this MDIO bus busy check necessary? The

Re: [PATCH v2 1/4] net: macb: Check MDIO state before read/write and use timeouts

2018-11-27 Thread Claudiu.Beznea
Hi Andrew, Harini, On 27.11.2018 07:36, Harini Katakam wrote: > Hi Claudiu, > On Mon, Nov 26, 2018 at 8:22 PM Andrew Lunn wrote: >> >> On Mon, Nov 26, 2018 at 02:46:01PM +, claudiu.bez...@microchip.com wrote: >>> Hi Harini, >>> >>> On 26.11.2018 09:07, Harini Katakam wrote: From: Harini

Re: [PATCH v2 1/4] net: macb: Check MDIO state before read/write and use timeouts

2018-11-26 Thread Harini Katakam
Hi Andrew, > > +#define MACB_IDLE_MASK (1 << MACB_IDLE_OFFSET) > > I think you could use the MACB_BIT() macro here. > > But otherwise, > > Reviewed-by: Andrew Lunn Thanks, will fix this in next series. Regards, Harini

Re: [PATCH v2 1/4] net: macb: Check MDIO state before read/write and use timeouts

2018-11-26 Thread Harini Katakam
Hi Claudiu, On Mon, Nov 26, 2018 at 8:22 PM Andrew Lunn wrote: > > On Mon, Nov 26, 2018 at 02:46:01PM +, claudiu.bez...@microchip.com wrote: > > Hi Harini, > > > > On 26.11.2018 09:07, Harini Katakam wrote: > > > From: Harini Katakam > > > > > > Replace the while loop in MDIO read/write funct

Re: [PATCH v2 1/4] net: macb: Check MDIO state before read/write and use timeouts

2018-11-26 Thread Andrew Lunn
On Mon, Nov 26, 2018 at 02:46:01PM +, claudiu.bez...@microchip.com wrote: > Hi Harini, > > On 26.11.2018 09:07, Harini Katakam wrote: > > From: Harini Katakam > > > > Replace the while loop in MDIO read/write functions with a timeout. > > In addition, add a check for MDIO bus busy before ini

Re: [PATCH v2 1/4] net: macb: Check MDIO state before read/write and use timeouts

2018-11-26 Thread Claudiu.Beznea
Hi Harini, On 26.11.2018 09:07, Harini Katakam wrote: > From: Harini Katakam > > Replace the while loop in MDIO read/write functions with a timeout. > In addition, add a check for MDIO bus busy before initiating a new > operation as well to make sure there is no ongoing MDIO operation. Is this

Re: [PATCH v2 1/4] net: macb: Check MDIO state before read/write and use timeouts

2018-11-26 Thread Andrew Lunn
On Mon, Nov 26, 2018 at 12:37:49PM +0530, Harini Katakam wrote: > From: Harini Katakam > > Replace the while loop in MDIO read/write functions with a timeout. > In addition, add a check for MDIO bus busy before initiating a new > operation as well to make sure there is no ongoing MDIO operation.

[PATCH v2 1/4] net: macb: Check MDIO state before read/write and use timeouts

2018-11-25 Thread Harini Katakam
From: Harini Katakam Replace the while loop in MDIO read/write functions with a timeout. In addition, add a check for MDIO bus busy before initiating a new operation as well to make sure there is no ongoing MDIO operation. Signed-off-by: Shubhrajyoti Datta Signed-off-by: Sai Pavan Boddu Signed