Re: [PATCH v2 08/16] spi: davinci: Remove uninitialized_var() usage

2020-07-02 Thread Joe Perches
On Thu, 2020-07-02 at 08:42 -0700, Kees Cook wrote: > On Thu, Jul 02, 2020 at 04:23:35PM +0100, Mark Brown wrote: > > On Thu, Jul 02, 2020 at 08:21:40AM -0700, Kees Cook wrote: > > > On Wed, Jul 01, 2020 at 09:39:20PM +0100, Mark Brown wrote: > > > > Please copy maintainers on patches :( > > > Hi!

Re: [PATCH v2 08/16] spi: davinci: Remove uninitialized_var() usage

2020-07-02 Thread Kees Cook
On Thu, Jul 02, 2020 at 04:23:35PM +0100, Mark Brown wrote: > On Thu, Jul 02, 2020 at 08:21:40AM -0700, Kees Cook wrote: > > On Wed, Jul 01, 2020 at 09:39:20PM +0100, Mark Brown wrote: > > > > Please copy maintainers on patches :( > > > Hi! Sorry about that; the CC list was giant, so I had opted

Re: [PATCH v2 08/16] spi: davinci: Remove uninitialized_var() usage

2020-07-02 Thread Mark Brown
On Thu, Jul 02, 2020 at 08:21:40AM -0700, Kees Cook wrote: > On Wed, Jul 01, 2020 at 09:39:20PM +0100, Mark Brown wrote: > > Please copy maintainers on patches :( > Hi! Sorry about that; the CC list was giant, so I had opted for using > subsystem mailing lists where possible. If you're going to

Re: [PATCH v2 08/16] spi: davinci: Remove uninitialized_var() usage

2020-07-02 Thread Kees Cook
On Wed, Jul 01, 2020 at 09:39:20PM +0100, Mark Brown wrote: > On Fri, Jun 19, 2020 at 08:29:59PM -0700, Kees Cook wrote: > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > > (or can in the future), and suppresses unrelated compiler warnings (e.g. > > "unused variable"). If

Re: [PATCH v2 08/16] spi: davinci: Remove uninitialized_var() usage

2020-07-01 Thread Mark Brown
On Fri, Jun 19, 2020 at 08:29:59PM -0700, Kees Cook wrote: > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings (e.g. > "unused variable"). If the compiler thinks it is uninitialized, either > simply initialize

[PATCH v2 08/16] spi: davinci: Remove uninitialized_var() usage

2020-06-19 Thread Kees Cook
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. As a precursor to removing[2