Re: [PATCH v2 0/5] strict netlink validation

2019-04-28 Thread David Ahern
On 4/28/19 1:32 PM, Johannes Berg wrote: > On Fri, 2019-04-26 at 20:28 -0600, David Ahern wrote: >> >> I agree with this set and will help moving forward. As I recall it >> requires follow up patches for each policy to set strict_start_type >> opting in to the strict checking. With that in place ne

Re: [PATCH v2 0/5] strict netlink validation

2019-04-28 Thread Johannes Berg
On Fri, 2019-04-26 at 20:28 -0600, David Ahern wrote: > > I agree with this set and will help moving forward. As I recall it > requires follow up patches for each policy to set strict_start_type > opting in to the strict checking. With that in place new userspace on > old kernels will get a failur

Re: [PATCH v2 0/5] strict netlink validation

2019-04-27 Thread David Miller
From: David Ahern Date: Fri, 26 Apr 2019 20:28:20 -0600 > On 4/26/19 6:07 AM, Johannes Berg wrote: >> Here's a respin, with the following changes: >> * change message when rejecting unknown attribute types (David Ahern) >> * drop nl80211 patch - I'll apply it separately >> * remove NL_VALIDATE

Re: [PATCH v2 0/5] strict netlink validation

2019-04-26 Thread David Ahern
On 4/26/19 6:07 AM, Johannes Berg wrote: > Here's a respin, with the following changes: > * change message when rejecting unknown attribute types (David Ahern) > * drop nl80211 patch - I'll apply it separately > * remove NL_VALIDATE_POLICY - we have a lot of calls to nla_parse() >that really

[PATCH v2 0/5] strict netlink validation

2019-04-26 Thread Johannes Berg
Here's a respin, with the following changes: * change message when rejecting unknown attribute types (David Ahern) * drop nl80211 patch - I'll apply it separately * remove NL_VALIDATE_POLICY - we have a lot of calls to nla_parse() that really should be without a policy as it has previously be