Re: [PATCH v2 0/3 net-next] Finish conversion of skb_frag_t to bio_vec

2019-07-30 Thread Jens Axboe
On 7/30/19 3:22 PM, David Miller wrote: > From: Jens Axboe > Date: Tue, 30 Jul 2019 20:49:09 + > >> Pretty appalled to see this abomination: >> >> net: Convert skb_frag_t to bio_vec >> >> There are a lot of users of frag->page_offset, so use a union >> to avoid converting those users today. >

Re: [PATCH v2 0/3 net-next] Finish conversion of skb_frag_t to bio_vec

2019-07-30 Thread David Miller
From: Jens Axboe Date: Tue, 30 Jul 2019 20:49:09 + > Pretty appalled to see this abomination: > > net: Convert skb_frag_t to bio_vec > > There are a lot of users of frag->page_offset, so use a union > to avoid converting those users today. > > Signed-off-by: Matthew Wilcox (Oracle) > Sign

Re: [PATCH v2 0/3 net-next] Finish conversion of skb_frag_t to bio_vec

2019-07-30 Thread David Miller
From: Jonathan Lemon Date: Tue, 30 Jul 2019 07:40:31 -0700 > The recent conversion of skb_frag_t to bio_vec did not include > skb_frag's page_offset. Add accessor functions for this field, > utilize them, and remove the union, restoring the original structure. > > v2: > - rename accessors >

Re: [PATCH v2 0/3 net-next] Finish conversion of skb_frag_t to bio_vec

2019-07-30 Thread Jens Axboe
On 7/30/19 8:40 AM, Jonathan Lemon wrote: > The recent conversion of skb_frag_t to bio_vec did not include > skb_frag's page_offset. Add accessor functions for this field, > utilize them, and remove the union, restoring the original structure. You can add: Reviewed-by: Jens Axboe Pretty appall

Re: [PATCH v2 0/3 net-next] Finish conversion of skb_frag_t to bio_vec

2019-07-30 Thread Jakub Kicinski
On Tue, 30 Jul 2019 07:40:31 -0700, Jonathan Lemon wrote: > The recent conversion of skb_frag_t to bio_vec did not include > skb_frag's page_offset. Add accessor functions for this field, > utilize them, and remove the union, restoring the original structure. Reviewed-by: Jakub Kicinski Thanks!

[PATCH v2 0/3 net-next] Finish conversion of skb_frag_t to bio_vec

2019-07-30 Thread Jonathan Lemon
The recent conversion of skb_frag_t to bio_vec did not include skb_frag's page_offset. Add accessor functions for this field, utilize them, and remove the union, restoring the original structure. v2: - rename accessors - follow kdoc conventions Jonathan Lemon (3): linux: Add page_offset ac