Em Wed, Dec 05, 2007 at 02:53:09PM +, Gerrit Renker escreveu:
> | Thanks, I folded this into the reorganized RX history handling patch,
> | together with reverting ccid3_hc_rx_packet_recv to very close to your
> | original patch, with this changes:
> |
> | 1. no need to calculate the payload s
| Thanks, I folded this into the reorganized RX history handling patch,
| together with reverting ccid3_hc_rx_packet_recv to very close to your
| original patch, with this changes:
|
| 1. no need to calculate the payload size for non data packets as this
|value won't be used.
| 2. Initialize h
Em Wed, Dec 05, 2007 at 01:55:11PM +, Gerrit Renker escreveu:
> | > @@ -788,8 +782,8 @@ static void ccid3_hc_rx_packet_recv(stru
> | > if (unlikely(hcrx->ccid3hcrx_state == TFRC_RSTATE_NO_DATA)) {
> | > if (is_data_packet) {
> | > do_feedback = FBACK_INITIAL;
> | >
Em Wed, Dec 05, 2007 at 11:19:44AM +, Gerrit Renker escreveu:
> This revision fixes a bug present in the per-socket allocation of RX history
> entries; identification of this bug is thanks to Arnaldo Carvalho de Melo.
>
> The bug was in not deallocating history entries when the allocation of
Em Wed, Dec 05, 2007 at 11:19:45AM +, Gerrit Renker escreveu:
> This fixes a problem in the initial revision of the patch: The loss interval
> history was not de-allocated when the initialisation of the packet history
> failed. The identification of this problem is also thanks due to Arnaldo.
Em Wed, Dec 05, 2007 at 11:19:46AM +, Gerrit Renker escreveu:
> This patch removes the following redundancies:
> * ccid3_hc_rx_update_s() is only called for data packets (that is what it
> should be called for);
> * each call to ccid3_hc_rx_update_s() is wrapped inside a "if
> (is_data_pa
| > @@ -788,8 +782,8 @@ static void ccid3_hc_rx_packet_recv(stru
| > if (unlikely(hcrx->ccid3hcrx_state == TFRC_RSTATE_NO_DATA)) {
| > if (is_data_packet) {
| > do_feedback = FBACK_INITIAL;
| > + hcrx->ccid3hcrx_s = payload_size;
| >
Em Wed, Dec 05, 2007 at 11:19:46AM +, Gerrit Renker escreveu:
> This patch removes the following redundancies:
> * ccid3_hc_rx_update_s() is only called for data packets (that is what it
> should be called for);
> * each call to ccid3_hc_rx_update_s() is wrapped inside a "if
> (is_data_pa
This revision fixes a bug present in the per-socket allocation of RX history
entries; identification of this bug is thanks to Arnaldo Carvalho de Melo.
The bug was in not deallocating history entries when the allocation of
one array element failed. The solution in this revised patch set is the
o
This fixes a problem in the initial revision of the patch: The loss interval
history was not de-allocated when the initialisation of the packet history
failed. The identification of this problem is also thanks due to Arnaldo.
The interdiff to the previous revision is:
--- b/net/dccp/ccid
This patch removes the following redundancies:
* ccid3_hc_rx_update_s() is only called for data packets (that is what it
should be called for);
* each call to ccid3_hc_rx_update_s() is wrapped inside a "if
(is_data_packet)" test';
* therefore testing each time if "len > 0" is redundant (poi
Orthogonal to the ongoing discussion of patches, here are updates
of existing ones. This is mainly to keep the test tree in synch;
I'd like to upload the new test tree since -rc4 is out.
Arnaldo has actually pointed out more bugs than I have given him credit for,
these are contained in this patch
12 matches
Mail list logo
