Re: [PATCH v2] virtio_net: fix missing dma unmap for resize

2024-01-03 Thread Jason Wang
On Thu, Jan 4, 2024 at 6:18 AM Michael S. Tsirkin wrote: > > On Wed, Jan 03, 2024 at 01:58:03PM -0800, Jakub Kicinski wrote: > > On Tue, 26 Dec 2023 17:43:33 +0800 Xuan Zhuo wrote: > > > For rq, we have three cases getting buffers from virtio core: > > > > > > 1. virtqueue_get_buf{,_ctx} > > > 2.

Re: [PATCH v2] virtio_net: fix missing dma unmap for resize

2024-01-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Tue, 26 Dec 2023 17:43:33 +0800 you wrote: > For rq, we have three cases getting buffers from virtio core: > > 1. virtqueue_get_buf{,_ctx} > 2. virtqueue_detach_unused_buf > 3. callback for virtqueue_resize > > But in

Re: [PATCH v2] virtio_net: fix missing dma unmap for resize

2024-01-03 Thread Michael S. Tsirkin
On Wed, Jan 03, 2024 at 01:58:03PM -0800, Jakub Kicinski wrote: > On Tue, 26 Dec 2023 17:43:33 +0800 Xuan Zhuo wrote: > > For rq, we have three cases getting buffers from virtio core: > > > > 1. virtqueue_get_buf{,_ctx} > > 2. virtqueue_detach_unused_buf > > 3. callback for virtqueue_resize > > >

Re: [PATCH v2] virtio_net: fix missing dma unmap for resize

2024-01-03 Thread Jakub Kicinski
On Tue, 26 Dec 2023 17:43:33 +0800 Xuan Zhuo wrote: > For rq, we have three cases getting buffers from virtio core: > > 1. virtqueue_get_buf{,_ctx} > 2. virtqueue_detach_unused_buf > 3. callback for virtqueue_resize > > But in commit 295525e29a5b("virtio_net: merge dma operations when > filling m

[PATCH v2] virtio_net: fix missing dma unmap for resize

2023-12-26 Thread Xuan Zhuo
For rq, we have three cases getting buffers from virtio core: 1. virtqueue_get_buf{,_ctx} 2. virtqueue_detach_unused_buf 3. callback for virtqueue_resize But in commit 295525e29a5b("virtio_net: merge dma operations when filling mergeable buffers"), I missed the dma unmap for the #3 case. That wi