Re: [PATCH v2] samples: bpf: make the use of xdp samples consistent

2019-06-26 Thread Daniel Borkmann
On 06/25/2019 02:55 AM, Daniel T. Lee wrote: > Currently, each xdp samples are inconsistent in the use. > Most of the samples fetch the interface with it's name. > (ex. xdp1, xdp2skb, xdp_redirect_cpu, xdp_sample_pkts, etc.) > > But some of the xdp samples are fetching the interface with > ifindex

Re: [PATCH v2] samples: bpf: make the use of xdp samples consistent

2019-06-25 Thread Song Liu
On Tue, Jun 25, 2019 at 5:09 AM Jesper Dangaard Brouer wrote: > > On Tue, 25 Jun 2019 11:08:22 +0200 > Toke Høiland-Jørgensen wrote: > > > "Daniel T. Lee" writes: > > > > > Currently, each xdp samples are inconsistent in the use. > > > Most of the samples fetch the interface with it's name. > >

Re: [PATCH v2] samples: bpf: make the use of xdp samples consistent

2019-06-25 Thread Jesper Dangaard Brouer
On Tue, 25 Jun 2019 11:08:22 +0200 Toke Høiland-Jørgensen wrote: > "Daniel T. Lee" writes: > > > Currently, each xdp samples are inconsistent in the use. > > Most of the samples fetch the interface with it's name. > > (ex. xdp1, xdp2skb, xdp_redirect_cpu, xdp_sample_pkts, etc.) > > > > But some

Re: [PATCH v2] samples: bpf: make the use of xdp samples consistent

2019-06-25 Thread Toke Høiland-Jørgensen
"Daniel T. Lee" writes: > Currently, each xdp samples are inconsistent in the use. > Most of the samples fetch the interface with it's name. > (ex. xdp1, xdp2skb, xdp_redirect_cpu, xdp_sample_pkts, etc.) > > But some of the xdp samples are fetching the interface with > ifindex by command argument

[PATCH v2] samples: bpf: make the use of xdp samples consistent

2019-06-24 Thread Daniel T. Lee
Currently, each xdp samples are inconsistent in the use. Most of the samples fetch the interface with it's name. (ex. xdp1, xdp2skb, xdp_redirect_cpu, xdp_sample_pkts, etc.) But some of the xdp samples are fetching the interface with ifindex by command argument. This commit enables xdp samples to

[PATCH v2] samples: bpf: make the use of xdp samples consistent

2019-06-24 Thread Daniel T. Lee
Currently, each xdp samples are inconsistent in the use. Most of the samples fetch the interface with it's name. (ex. xdp1, xdp2skb, xdp_redirect_cpu, xdp_sample_pkts, etc.) But some of the xdp samples are fetching the interface with ifindex by command argument. This commit enables xdp samples to