RE: [PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-03 Thread Mario_Limonciello
l.com; > anthony.w...@canonical.com > Subject: Re: [PATCH v2] r8152: Add support for setting MAC to system's > Auxiliary MAC address > > On Thu, Jun 02, 2016 at 06:32:42PM +, mario_limoncie...@dell.com > wrote: > > > And you want to check this for all Dell devices?

RE: [PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-03 Thread Mario_Limonciello
> -Original Message- > From: Hayes Wang [mailto:hayesw...@realtek.com] > Sent: Friday, June 3, 2016 4:44 AM > To: Limonciello, Mario > Cc: LKML ; Netdev > ; Linux USB ; > pali.ro...@gmail.com; anthony.w...@canonical.com; Greg KH > > Subject: RE: [PATCH v2] r81

RE: [PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-03 Thread Mario_Limonciello
r.kernel.org; pali.ro...@gmail.com; anthony.w...@canonical.com > Subject: Re: [PATCH v2] r8152: Add support for setting MAC to system's > Auxiliary MAC address > > On Thu, Jun 02, 2016 at 07:04:32PM +, mario_limoncie...@dell.com > wrote: > > > -Original Message--

RE: [PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-03 Thread Hayes Wang
Mario Limonciello [mailto:mario_limoncie...@dell.com] > Sent: Friday, June 03, 2016 12:58 AM [...] > @@ -500,6 +502,7 @@ enum rtl8152_flags { > SELECTIVE_SUSPEND, > PHY_RESET, > SCHEDULE_NAPI, > + MAC_PASSTHRU = 0, I don't think you have to give this a value. > }; > [...]

Re: [PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-02 Thread Greg KH
On Thu, Jun 02, 2016 at 06:32:42PM +, mario_limoncie...@dell.com wrote: > > And you want to check this for all Dell devices? Please be model > > specific, I doubt a bunch of Dell servers wants to run this code... > > > > Tracking model specific is really going to turn into a giant list never

Re: [PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-02 Thread Andrew Lunn
..@realtek.com; linux- > > ker...@vger.kernel.org; netdev@vger.kernel.org; linux- > > u...@vger.kernel.org; pali.ro...@gmail.com; anthony.w...@canonical.com > > Subject: Re: [PATCH v2] r8152: Add support for setting MAC to system's > > Auxiliary MAC address > > &g

RE: [PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-02 Thread Mario_Limonciello
r.kernel.org; pali.ro...@gmail.com; anthony.w...@canonical.com > Subject: Re: [PATCH v2] r8152: Add support for setting MAC to system's > Auxiliary MAC address > > > > And you want to check this for all Dell devices? Please be model > > > specific, I

Re: [PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-02 Thread Andrew Lunn
> > And you want to check this for all Dell devices? Please be model > > specific, I doubt a bunch of Dell servers wants to run this code... > > > > Tracking model specific is really going to turn into a giant list never > ending list. > To drill down more specifically, I can match on chassis t

RE: [PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-02 Thread Mario_Limonciello
e: [PATCH v2] r8152: Add support for setting MAC to system's > Auxiliary MAC address > > On Thu, Jun 02, 2016 at 11:58:07AM -0500, Mario Limonciello wrote: > > Dell systems with Type-C ports have support for a persistent system > > specific MAC address when used with Dell Type-

Re: [PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-02 Thread Greg KH
On Thu, Jun 02, 2016 at 11:58:07AM -0500, Mario Limonciello wrote: > Dell systems with Type-C ports have support for a persistent system > specific MAC address when used with Dell Type-C docks and dongles. > This means a dock plugged into two different systems will show different > (but persistent)

[PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-02 Thread Mario Limonciello
This adjusts a lot of concerns that have been raised on LKML. Changes from v1: * Lots of error checking around bad ACPI data * Only activate on Dell system vendor DMI string * Use hex2bin instead of inventing a wheel * Copy MAC to both dev_addr and sa_data * Track and set only for one NIC at

[PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address

2016-06-02 Thread Mario Limonciello
Dell systems with Type-C ports have support for a persistent system specific MAC address when used with Dell Type-C docks and dongles. This means a dock plugged into two different systems will show different (but persistent) MAC addresses. Dell Type-C docks and dongles use the r8152 driver. This