Re: [PATCH v2] net:qrtr: fix atomic idr allocation in qrtr_port_assign()

2021-03-29 Thread Manivannan Sadhasivam
On Mon, Mar 29, 2021 at 06:55:56PM +0800, Du Cheng wrote: > On Sun, Mar 28, 2021 at 11:04:17AM +0100, Matthew Wilcox wrote: > > On Sun, Mar 28, 2021 at 08:56:17AM +0200, Greg Kroah-Hartman wrote: > > > On Sat, Mar 27, 2021 at 03:51:10PM +, Matthew Wilcox wrote: > > > > On Sat, Mar 27, 2021 at 0

Re: [PATCH v2] net:qrtr: fix atomic idr allocation in qrtr_port_assign()

2021-03-29 Thread Du Cheng
On Sun, Mar 28, 2021 at 11:04:17AM +0100, Matthew Wilcox wrote: > On Sun, Mar 28, 2021 at 08:56:17AM +0200, Greg Kroah-Hartman wrote: > > On Sat, Mar 27, 2021 at 03:51:10PM +, Matthew Wilcox wrote: > > > On Sat, Mar 27, 2021 at 03:31:18PM +0100, Greg Kroah-Hartman wrote: > > > > On Sat, Mar 27,

Re: [PATCH v2] net:qrtr: fix atomic idr allocation in qrtr_port_assign()

2021-03-28 Thread Matthew Wilcox
On Sun, Mar 28, 2021 at 08:56:17AM +0200, Greg Kroah-Hartman wrote: > On Sat, Mar 27, 2021 at 03:51:10PM +, Matthew Wilcox wrote: > > On Sat, Mar 27, 2021 at 03:31:18PM +0100, Greg Kroah-Hartman wrote: > > > On Sat, Mar 27, 2021 at 10:25:20PM +0800, Du Cheng wrote: > > > > On Sat, Mar 27, 2021

Re: [PATCH v2] net:qrtr: fix atomic idr allocation in qrtr_port_assign()

2021-03-27 Thread Greg Kroah-Hartman
On Sat, Mar 27, 2021 at 03:51:10PM +, Matthew Wilcox wrote: > On Sat, Mar 27, 2021 at 03:31:18PM +0100, Greg Kroah-Hartman wrote: > > On Sat, Mar 27, 2021 at 10:25:20PM +0800, Du Cheng wrote: > > > On Sat, Mar 27, 2021 at 03:12:14PM +0100, Greg Kroah-Hartman wrote: > > > > Adding the xarray mai

Re: [PATCH v2] net:qrtr: fix atomic idr allocation in qrtr_port_assign()

2021-03-27 Thread Matthew Wilcox
On Sat, Mar 27, 2021 at 03:31:18PM +0100, Greg Kroah-Hartman wrote: > On Sat, Mar 27, 2021 at 10:25:20PM +0800, Du Cheng wrote: > > On Sat, Mar 27, 2021 at 03:12:14PM +0100, Greg Kroah-Hartman wrote: > > > Adding the xarray maintainer... > > > > > > On Sat, Mar 27, 2021 at 10:07:02PM +0800, Du Che

Re: [PATCH v2] net:qrtr: fix atomic idr allocation in qrtr_port_assign()

2021-03-27 Thread Greg Kroah-Hartman
On Sat, Mar 27, 2021 at 10:25:20PM +0800, Du Cheng wrote: > On Sat, Mar 27, 2021 at 03:12:14PM +0100, Greg Kroah-Hartman wrote: > > Adding the xarray maintainer... > > > > On Sat, Mar 27, 2021 at 10:07:02PM +0800, Du Cheng wrote: > > > add idr_preload() and idr_preload_end() around idr_alloc_u32(G

Re: [PATCH v2] net:qrtr: fix atomic idr allocation in qrtr_port_assign()

2021-03-27 Thread Du Cheng
On Sat, Mar 27, 2021 at 03:12:14PM +0100, Greg Kroah-Hartman wrote: > Adding the xarray maintainer... > > On Sat, Mar 27, 2021 at 10:07:02PM +0800, Du Cheng wrote: > > add idr_preload() and idr_preload_end() around idr_alloc_u32(GFP_ATOMIC) > > due to internal use of per_cpu variables, which requi

Re: [PATCH v2] net:qrtr: fix atomic idr allocation in qrtr_port_assign()

2021-03-27 Thread Greg Kroah-Hartman
Adding the xarray maintainer... On Sat, Mar 27, 2021 at 10:07:02PM +0800, Du Cheng wrote: > add idr_preload() and idr_preload_end() around idr_alloc_u32(GFP_ATOMIC) > due to internal use of per_cpu variables, which requires preemption > disabling/enabling. > > reported as "BUG: "using smp_process

[PATCH v2] net:qrtr: fix atomic idr allocation in qrtr_port_assign()

2021-03-27 Thread Du Cheng
add idr_preload() and idr_preload_end() around idr_alloc_u32(GFP_ATOMIC) due to internal use of per_cpu variables, which requires preemption disabling/enabling. reported as "BUG: "using smp_processor_id() in preemptible" by syzkaller Reported-by: syzbot+3eec59e770685e3dc...@syzkaller.appspotmail.