Re: [PATCH v2] net: phy: Have __phy_modify return 0 on success

2018-01-15 Thread David Miller
From: Andrew Lunn Date: Fri, 12 Jan 2018 15:01:36 +0100 > __phy_modify would return the old value of the register before it was > modified. Thus on success, it does not return 0, but a positive value. > Thus functions using phy_modify, which is a wrapper around > __phy_modify, can start returning

Re: [PATCH v2] net: phy: Have __phy_modify return 0 on success

2018-01-15 Thread Niklas Cassel
Tested-by: Niklas Cassel On Fri, Jan 12, 2018 at 03:01:36PM +0100, Andrew Lunn wrote: > __phy_modify would return the old value of the register before it was > modified. Thus on success, it does not return 0, but a positive value. > Thus functions using phy_modify, which is a wrapper around > __p

Re: [PATCH v2] net: phy: Have __phy_modify return 0 on success

2018-01-14 Thread David Miller
From: Andrew Lunn Date: Sun, 14 Jan 2018 19:04:11 +0100 > Is there any particular reason you have not picked up this patch? Do > you want more testing? An O.K. from Russell? I just haven't gotten to it yet, and it's the weekend, so...

Re: [PATCH v2] net: phy: Have __phy_modify return 0 on success

2018-01-14 Thread Andrew Lunn
On Fri, Jan 12, 2018 at 03:01:36PM +0100, Andrew Lunn wrote: > __phy_modify would return the old value of the register before it was > modified. Thus on success, it does not return 0, but a positive value. > Thus functions using phy_modify, which is a wrapper around > __phy_modify, can start return

[PATCH v2] net: phy: Have __phy_modify return 0 on success

2018-01-12 Thread Andrew Lunn
__phy_modify would return the old value of the register before it was modified. Thus on success, it does not return 0, but a positive value. Thus functions using phy_modify, which is a wrapper around __phy_modify, can start returning > 0 on success, rather than 0. As a result, breakage has been not