Re: [PATCH v2] net: openvswitch: pass NULL for unused parameters

2020-09-02 Thread Tom Rix
On 9/1/20 1:11 PM, David Miller wrote: > From: t...@redhat.com > Date: Sun, 30 Aug 2020 14:26:30 -0700 > >> Passing unused parameters is a waste. > Poorly predicted branches are an even bigger waste. > > I'm not a big fan of this change and others have asked for performance > analysis to be perfo

Re: [PATCH v2] net: openvswitch: pass NULL for unused parameters

2020-09-01 Thread David Miller
From: t...@redhat.com Date: Sun, 30 Aug 2020 14:26:30 -0700 > Passing unused parameters is a waste. Poorly predicted branches are an even bigger waste. I'm not a big fan of this change and others have asked for performance analysis to be performed. So I'm not applying this as-is, sorry. It's a

Re: [PATCH v2] net: openvswitch: pass NULL for unused parameters

2020-08-31 Thread Eelco Chaudron
On 31 Aug 2020, at 9:50, Eelco Chaudron wrote: On 30 Aug 2020, at 23:26, t...@redhat.com wrote: From: Tom Rix clang static analysis flags these problems flow_table.c:713:2: warning: The expression is an uninitialized value. The computed value will also be garbage (*n_mask_hit)+

Re: [PATCH v2] net: openvswitch: pass NULL for unused parameters

2020-08-31 Thread Eelco Chaudron
On 30 Aug 2020, at 23:26, t...@redhat.com wrote: From: Tom Rix clang static analysis flags these problems flow_table.c:713:2: warning: The expression is an uninitialized value. The computed value will also be garbage (*n_mask_hit)++; ^~~ flow_table.c:748:5: wa

[PATCH v2] net: openvswitch: pass NULL for unused parameters

2020-08-30 Thread trix
From: Tom Rix clang static analysis flags these problems flow_table.c:713:2: warning: The expression is an uninitialized value. The computed value will also be garbage (*n_mask_hit)++; ^~~ flow_table.c:748:5: warning: The expression is an uninitialized value. The