Re: [PATCH v2] net: ethernet: mtk_eth_soc: fix mtu warning

2020-07-09 Thread Andrew Lunn
> Are there any plans to solve these warnings for Marvell 88e6xxx DSA ports? Hi Russell I have patches for FEC + mv88e6xxx. I should post them. Andrew

Re: [PATCH v2] net: ethernet: mtk_eth_soc: fix mtu warning

2020-07-09 Thread Frank Wunderlich
Am 9. Juli 2020 22:31:34 MESZ schrieb Russell King - ARM Linux admin : >Are there any plans to solve these warnings for Marvell 88e6xxx DSA >ports? Maybe it's a better idea to restore previous condition? if (ret && ret != -EOPNOTSUPP) Or use another loglevel (dev_dbg) regards Frank

Re: [PATCH v2] net: ethernet: mtk_eth_soc: fix mtu warning

2020-07-09 Thread Russell King - ARM Linux admin
On Thu, Jul 09, 2020 at 03:41:15PM +0200, Andrew Lunn wrote: > On Thu, Jul 09, 2020 at 07:57:42AM +0200, Frank Wunderlich wrote: > > From: René van Dorst > > > > in recent Kernel-Versions there are warnings about incorrect MTU-Size > > like these: > > > > mt7530 mdio-bus:00: nonfatal error -95 s

Re: Re: [PATCH v2] net: ethernet: mtk_eth_soc: fix mtu warning

2020-07-09 Thread Andrew Lunn
On Thu, Jul 09, 2020 at 09:48:01PM +0200, Frank Wunderlich wrote: > > Gesendet: Donnerstag, 09. Juli 2020 um 15:41 Uhr > > Von: "Andrew Lunn" > > > > + eth->netdev[id]->max_mtu = 1536; > > > > I assume this is enough to make the DSA warning go away, but it is the > > true max? I have a similar pa

Aw: Re: [PATCH v2] net: ethernet: mtk_eth_soc: fix mtu warning

2020-07-09 Thread Frank Wunderlich
> Gesendet: Donnerstag, 09. Juli 2020 um 15:41 Uhr > Von: "Andrew Lunn" > > + eth->netdev[id]->max_mtu = 1536; > > I assume this is enough to make the DSA warning go away, but it is the > true max? I have a similar patch for the FEC driver which i should > post sometime. Reviewing the FEC code

Re: [PATCH v2] net: ethernet: mtk_eth_soc: fix mtu warning

2020-07-09 Thread Andrew Lunn
On Thu, Jul 09, 2020 at 07:57:42AM +0200, Frank Wunderlich wrote: > From: René van Dorst > > in recent Kernel-Versions there are warnings about incorrect MTU-Size > like these: > > mt7530 mdio-bus:00: nonfatal error -95 setting MTU on port x > eth0: mtu greater than device maximum > mtk_soc_eth

[PATCH v2] net: ethernet: mtk_eth_soc: fix mtu warning

2020-07-08 Thread Frank Wunderlich
From: René van Dorst in recent Kernel-Versions there are warnings about incorrect MTU-Size like these: mt7530 mdio-bus:00: nonfatal error -95 setting MTU on port x eth0: mtu greater than device maximum mtk_soc_eth 1b10.ethernet eth0: error -22 setting MTU to include DSA overhead Fixes: bfc