Re: [PATCH v2] net: Add eth_platform_get_mac_address() helper.

2016-01-06 Thread David Miller
From: Joe Perches Date: Wed, 06 Jan 2016 15:32:24 -0800 > On Thu, 2016-01-07 at 00:26 +0100, Bjørn Mork wrote: >> Joe Perches writes: >> > On Wed, 2016-01-06 at 16:33 -0500, David Miller wrote: >> > > A repeating pattern in drivers has become to use OF node information >> > > and, if not found,

Re: [PATCH v2] net: Add eth_platform_get_mac_address() helper.

2016-01-06 Thread Joe Perches
On Wed, 2016-01-06 at 19:01 -0500, David Miller wrote: > The caller checks for NULL, and this is the default implementation > doing precisely what it is meant to do. Yeah, I noticed that later. Nevermind... cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe netdev" in the bo

Re: [PATCH v2] net: Add eth_platform_get_mac_address() helper.

2016-01-06 Thread Bjørn Mork
Joe Perches writes: > On Thu, 2016-01-07 at 00:26 +0100, Bjørn Mork wrote: >> Joe Perches writes: >> > On Wed, 2016-01-06 at 16:33 -0500, David Miller wrote: >> > > A repeating pattern in drivers has become to use OF node information >> > > and, if not found, platform specific host information to

Re: [PATCH v2] net: Add eth_platform_get_mac_address() helper.

2016-01-06 Thread Joe Perches
On Thu, 2016-01-07 at 00:26 +0100, Bjørn Mork wrote: > Joe Perches writes: > > On Wed, 2016-01-06 at 16:33 -0500, David Miller wrote: > > > A repeating pattern in drivers has become to use OF node information > > > and, if not found, platform specific host information to extract the > > > ethernet

Re: [PATCH v2] net: Add eth_platform_get_mac_address() helper.

2016-01-06 Thread Bjørn Mork
Joe Perches writes: > On Wed, 2016-01-06 at 16:33 -0500, David Miller wrote: >> A repeating pattern in drivers has become to use OF node information >> and, if not found, platform specific host information to extract the >> ethernet address for a given device. > [] >> diff --git a/include/linux/et

Re: [PATCH v2] net: Add eth_platform_get_mac_address() helper.

2016-01-06 Thread Joe Perches
On Wed, 2016-01-06 at 16:33 -0500, David Miller wrote: > A repeating pattern in drivers has become to use OF node information > and, if not found, platform specific host information to extract the > ethernet address for a given device. [] > diff --git a/include/linux/etherdevice.h b/include/linux/e

Re: [PATCH v2] net: Add eth_platform_get_mac_address() helper.

2016-01-06 Thread Sowmini Varadhan
On (01/06/16 16:33), David Miller wrote: > > Signed-off-by: David S. Miller Acked-by: Sowmini Varadhan > > As promised back in November, I'm commiting this into net-next > now. I'd work on the conversions of existing drivers, but I'd > rather someone with access to the hardware to so. I'll

[PATCH v2] net: Add eth_platform_get_mac_address() helper.

2016-01-06 Thread David Miller
A repeating pattern in drivers has become to use OF node information and, if not found, platform specific host information to extract the ethernet address for a given device. Currently this is done with a call to of_get_mac_address() and then some ifdef'd stuff for SPARC. Consolidate this into a