Re: [PATCH v2] net/mlx4_en: fix potential use-after-free with dma_unmap_page

2018-05-02 Thread David Miller
From: Tariq Toukan Date: Wed, 2 May 2018 16:50:28 +0300 > This patch fixes an issue existing in old kernels. It is not relevant > per latest code. > > So I'm not sure about the process. After I review it, do I just submit > it again for -stable? If that's the case, yes that is what you do, just

Re: [PATCH v2] net/mlx4_en: fix potential use-after-free with dma_unmap_page

2018-05-02 Thread Tariq Toukan
On 28/04/2018 2:48 AM, David Miller wrote: From: Sarah Newman Date: Wed, 25 Apr 2018 21:00:34 -0700 When swiotlb is in use, calling dma_unmap_page means that the original page mapped with dma_map_page must still be valid as swiotlb will copy data from its internal cache back to the originall

Re: [PATCH v2] net/mlx4_en: fix potential use-after-free with dma_unmap_page

2018-04-27 Thread David Miller
From: Sarah Newman Date: Wed, 25 Apr 2018 21:00:34 -0700 > When swiotlb is in use, calling dma_unmap_page means that > the original page mapped with dma_map_page must still be valid > as swiotlb will copy data from its internal cache back to the > originally requested DMA location. When GRO is en

[PATCH v2] net/mlx4_en: fix potential use-after-free with dma_unmap_page

2018-04-25 Thread Sarah Newman
When swiotlb is in use, calling dma_unmap_page means that the original page mapped with dma_map_page must still be valid as swiotlb will copy data from its internal cache back to the originally requested DMA location. When GRO is enabled, all references to the original frag may be put before mlx4_e