Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-26 Thread Sergej Bauer
On Saturday, January 23, 2021 4:32:38 AM MSK Andrew Lunn wrote: > > it migth be helpful for developers work on userspace networking tools with > > PHY-less lan743x > > (the interface even could not be brought up) > > > of course, there nothing much to do without TP port but the difference is > >

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-26 Thread Sergej Bauer
On Saturday, January 23, 2021 4:39:47 AM MSK Florian Fainelli wrote: > On 1/22/2021 5:01 PM, Sergej Bauer wrote: > > On Saturday, January 23, 2021 3:01:47 AM MSK Florian Fainelli wrote: > >> On 1/22/2021 3:58 PM, Sergej Bauer wrote: > >>> On Saturday, January 23, 2021 2:23:25 AM MSK Andrew Lunn wro

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-26 Thread Sergej Bauer
On Saturday, January 23, 2021 2:23:25 AM MSK Andrew Lunn wrote: > > > > @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct > > > > lan743x_adapter *adapter)> > > > > > > > > struct net_device *netdev = adapter->netdev; > > > > > > > > phy_stop(netdev->phydev); > >

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Sergej Bauer
resending answer to all: On Saturday, January 23, 2021 4:32:38 AM MSK Andrew Lunn wrote: > > it migth be helpful for developers work on userspace networking tools with > > PHY-less lan743x > > (the interface even could not be brought up) > > > of course, there nothing much to do without TP port b

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Florian Fainelli
On 1/22/2021 5:01 PM, Sergej Bauer wrote: > On Saturday, January 23, 2021 3:01:47 AM MSK Florian Fainelli wrote: >> On 1/22/2021 3:58 PM, Sergej Bauer wrote: >>> On Saturday, January 23, 2021 2:23:25 AM MSK Andrew Lunn wrote: >>> @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct >>

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Andrew Lunn
> it migth be helpful for developers work on userspace networking tools with > PHY-less lan743x (the interface even could not be brought up) > of course, there nothing much to do without TP port but the difference is > representative. > > sbauer@metamini ~$ sudo ethtool eth7 > Settings for eth7:

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Sergej Bauer
On Saturday, January 23, 2021 3:01:47 AM MSK Florian Fainelli wrote: > On 1/22/2021 3:58 PM, Sergej Bauer wrote: > > On Saturday, January 23, 2021 2:23:25 AM MSK Andrew Lunn wrote: > > @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct > > lan743x_adapter *adapter)> > > >

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Florian Fainelli
On 1/22/2021 3:58 PM, Sergej Bauer wrote: > On Saturday, January 23, 2021 2:23:25 AM MSK Andrew Lunn wrote: > @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct > lan743x_adapter *adapter)> > > struct net_device *netdev = adapter->netdev; > > phy_stop(netd

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Sergej Bauer
On Saturday, January 23, 2021 2:23:25 AM MSK Andrew Lunn wrote: > > > > @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct > > > > lan743x_adapter *adapter)> > > > > > > > > struct net_device *netdev = adapter->netdev; > > > > > > > > phy_stop(netdev->phydev); > >

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Andrew Lunn
> > > @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct > > > lan743x_adapter *adapter)> > > > struct net_device *netdev = adapter->netdev; > > > > > > phy_stop(netdev->phydev); > > > > > > - phy_disconnect(netdev->phydev); > > > - netdev->phydev = NULL; > > > + if (phy_is_pseudo

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Sergej Bauer
On Saturday, January 23, 2021 1:08:03 AM MSK Andrew Lunn wrote: > On Sat, Jan 23, 2021 at 12:42:41AM +0300, Sergej Bauer wrote: > > From: sba...@blackbox.su > > > > v1->v2: > > switch to using of fixed_phy as was suggested by Andrew and Florian > > also features-related parts are removed >

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Sergej Bauer
On Saturday, January 23, 2021 12:52:48 AM MSK Florian Fainelli wrote: > On 1/22/2021 1:42 PM, Sergej Bauer wrote: > > From: sba...@blackbox.su > > > > v1->v2: > > switch to using of fixed_phy as was suggested by Andrew and Florian > > also features-related parts are removed > > > > Previo

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Andrew Lunn
On Sat, Jan 23, 2021 at 12:42:41AM +0300, Sergej Bauer wrote: > From: sba...@blackbox.su > > v1->v2: > switch to using of fixed_phy as was suggested by Andrew and Florian > also features-related parts are removed This is not using fixed_phy, at least not in the normal way. Take a loo

[PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Sergej Bauer
From: sba...@blackbox.su v1->v2: switch to using of fixed_phy as was suggested by Andrew and Florian also features-related parts are removed Previous versions can be found at: v1: initial version https://lkml.org/lkml/2020/9/17/1272 Signed-off-by: Sergej Bauer diff --gi

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Florian Fainelli
On 1/22/2021 1:42 PM, Sergej Bauer wrote: > From: sba...@blackbox.su > > v1->v2: > switch to using of fixed_phy as was suggested by Andrew and Florian > also features-related parts are removed > > Previous versions can be found at: > v1: > initial version > https://lkml.org/l