Re: [PATCH v2] gre: Avoid kernel panic by clearing IPCB before dst_link_failure called

2016-02-21 Thread Bernie Harris
> Again, I want to see this implemented in a way which causes things to be > treated consistently across all tunneling types. > > Which means fixing the exact problem, IPCB(skb)->opt needing initilization. > > Thanks. Thanks for the reply. I have revised my patch to apply to the range of tunnel t

Re: [PATCH v2] gre: Avoid kernel panic by clearing IPCB before dst_link_failure called

2016-02-17 Thread David Miller
From: Bernie Harris Date: Tue, 16 Feb 2016 14:10:16 +1300 > skb->cb may contain data from previous layers (in the observed case the > qdisc layer). In the observed scenario, the data was misinterpreted as > ip header options, which later caused the ihl to be set to an invalid > value (<5). This r

[PATCH v2] gre: Avoid kernel panic by clearing IPCB before dst_link_failure called

2016-02-15 Thread Bernie Harris
skb->cb may contain data from previous layers (in the observed case the qdisc layer). In the observed scenario, the data was misinterpreted as ip header options, which later caused the ihl to be set to an invalid value (<5). This resulted in an infinite loop in the mips implementation of ip_fast_cs