Re: [PATCH v2] geneve: remove use of internal IP header when calling IP_ECN_decapsulate

2015-09-21 Thread John W. Linville
On Sun, Sep 20, 2015 at 10:24:59PM -0700, David Miller wrote: > From: "John W. Linville" > Date: Thu, 17 Sep 2015 16:34:54 -0400 > > > This seems to have been a "thinko". IP_ECN_decapsulate needs info > > from both internal and external headers. > > > > Signed-off-by: John W. Linville > > ---

Re: [PATCH v2] geneve: remove use of internal IP header when calling IP_ECN_decapsulate

2015-09-20 Thread David Miller
From: "John W. Linville" Date: Thu, 17 Sep 2015 16:34:54 -0400 > This seems to have been a "thinko". IP_ECN_decapsulate needs info > from both internal and external headers. > > Signed-off-by: John W. Linville > --- > v2 -- ensure the collect_md path still calls IP_ECN_decapsulate Judging by

Re: [PATCH v2] geneve: remove use of internal IP header when calling IP_ECN_decapsulate

2015-09-18 Thread Jesse Gross
On Fri, Sep 18, 2015 at 6:36 PM, John W. Linville wrote: > On Fri, Sep 18, 2015 at 02:49:30PM -0700, Jesse Gross wrote: >> On Fri, Sep 18, 2015 at 1:40 PM, John W. Linville >> wrote: >> > On Fri, Sep 18, 2015 at 01:30:36PM -0700, Jesse Gross wrote: >> >> On Thu, Sep 17, 2015 at 1:34 PM, John W. L

Re: [PATCH v2] geneve: remove use of internal IP header when calling IP_ECN_decapsulate

2015-09-18 Thread John W. Linville
On Fri, Sep 18, 2015 at 02:49:30PM -0700, Jesse Gross wrote: > On Fri, Sep 18, 2015 at 1:40 PM, John W. Linville > wrote: > > On Fri, Sep 18, 2015 at 01:30:36PM -0700, Jesse Gross wrote: > >> On Thu, Sep 17, 2015 at 1:34 PM, John W. Linville > >> wrote: > >> > This seems to have been a "thinko".

Re: [PATCH v2] geneve: remove use of internal IP header when calling IP_ECN_decapsulate

2015-09-18 Thread Jesse Gross
On Fri, Sep 18, 2015 at 1:40 PM, John W. Linville wrote: > On Fri, Sep 18, 2015 at 01:30:36PM -0700, Jesse Gross wrote: >> On Thu, Sep 17, 2015 at 1:34 PM, John W. Linville >> wrote: >> > This seems to have been a "thinko". IP_ECN_decapsulate needs info >> > from both internal and external heade

Re: [PATCH v2] geneve: remove use of internal IP header when calling IP_ECN_decapsulate

2015-09-18 Thread John W. Linville
On Fri, Sep 18, 2015 at 01:30:36PM -0700, Jesse Gross wrote: > On Thu, Sep 17, 2015 at 1:34 PM, John W. Linville > wrote: > > This seems to have been a "thinko". IP_ECN_decapsulate needs info > > from both internal and external headers. > > > > Signed-off-by: John W. Linville > > This looks goo

Re: [PATCH v2] geneve: remove use of internal IP header when calling IP_ECN_decapsulate

2015-09-18 Thread Jesse Gross
On Thu, Sep 17, 2015 at 1:34 PM, John W. Linville wrote: > This seems to have been a "thinko". IP_ECN_decapsulate needs info > from both internal and external headers. > > Signed-off-by: John W. Linville This looks good to me although I realized that the transmit path is also conditional based

[PATCH v2] geneve: remove use of internal IP header when calling IP_ECN_decapsulate

2015-09-17 Thread John W. Linville
This seems to have been a "thinko". IP_ECN_decapsulate needs info from both internal and external headers. Signed-off-by: John W. Linville --- v2 -- ensure the collect_md path still calls IP_ECN_decapsulate drivers/net/geneve.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --