On 04/05/2018 03:46 AM, Marcel Holtmann wrote:
By the way, what is you opinion on replacing crypto_shash_descsize(ctx) with
PAGE_SIZE / 8 in SHASH_DESC_ON_STACK?
Does it work for you?
isn’t that just waste?
Agree.
The macro itself is this.
#define SHASH_DESC_ON_STACK(shash, ctx)
Hi Marcel,
On 04/05/2018 02:23 AM, Marcel Holtmann wrote:
so I took this patch back out of bluetooth-next before sending the pull
request. I think the discussion on how to fix SHASH_DESC_ON_STACK macro needs
to complete first. Once that has concluded we can revisit if this patch is
still nee
Hi Gustavo,
>> so I took this patch back out of bluetooth-next before sending the pull
>> request. I think the discussion on how to fix SHASH_DESC_ON_STACK macro
>> needs to complete first. Once that has concluded we can revisit if this
>> patch is still needed or if another solution has been f
Hi Gustavo,
> In preparation to enabling -Wvla, remove VLA and replace it
> with dynamic memory allocation instead.
>
> The use of stack Variable Length Arrays needs to be avoided, as they
> can be a vector for stack exhaustion, which can be both a runtime bug
> or a security flaw. Also, in gener
On 03/21/2018 08:45 AM, Marcel Holtmann wrote:
Hi Gustavo,
In preparation to enabling -Wvla, remove VLA and replace it
with dynamic memory allocation instead.
The use of stack Variable Length Arrays needs to be avoided, as they
can be a vector for stack exhaustion, which can be both a runtim
Hi Gustavo,
> In preparation to enabling -Wvla, remove VLA and replace it
> with dynamic memory allocation instead.
>
> The use of stack Variable Length Arrays needs to be avoided, as they
> can be a vector for stack exhaustion, which can be both a runtime bug
> or a security flaw. Also, in gener
In preparation to enabling -Wvla, remove VLA and replace it
with dynamic memory allocation instead.
The use of stack Variable Length Arrays needs to be avoided, as they
can be a vector for stack exhaustion, which can be both a runtime bug
or a security flaw. Also, in general, as code evolves it is
