Re: [PATCH v2] ARM64: dts: meson-axg: add ethernet mac controller

2017-12-14 Thread Yixun Lan
Hi Jerome: On 12/15/17 00:45, Jerome Brunet wrote: > On Thu, 2017-12-14 at 11:02 +0800, Yixun Lan wrote: >> --- >> Changes in v2 since [1]: >> - rebase to kevin's v4.16/dt64 branch >> - add Neil's Reviewed-by >> - move clock info to board.dts instead of in soc.dtsi > > You got this comment reg

Re: [PATCH v2] ARM64: dts: meson-axg: add ethernet mac controller

2017-12-14 Thread Jerome Brunet
On Thu, 2017-12-14 at 11:02 +0800, Yixun Lan wrote: > --- > Changes in v2 since [1]: > - rebase to kevin's v4.16/dt64 branch > - add Neil's Reviewed-by > - move clock info to board.dts instead of in soc.dtsi You got this comment regarding the pwm clock setup. the setup of the pwm clocks depends

Re: [PATCH v2] ARM64: dts: meson-axg: add ethernet mac controller

2017-12-14 Thread Jerome Brunet
On Thu, 2017-12-14 at 11:02 +0800, Yixun Lan wrote: > Add DT info for the stmmac ethernet MAC which found in > the Amlogic's Meson-AXG SoC, also describe the ethernet > pinctrl & clock information here. > > This is tested in the S400 dev board which use a RTL8211F PHY, > and the pins connect to th

[PATCH v2] ARM64: dts: meson-axg: add ethernet mac controller

2017-12-13 Thread Yixun Lan
Add DT info for the stmmac ethernet MAC which found in the Amlogic's Meson-AXG SoC, also describe the ethernet pinctrl & clock information here. This is tested in the S400 dev board which use a RTL8211F PHY, and the pins connect to the 'eth_rgmii_y_pins' group. Reviewed-by: Neil Armstrong Signed