Re: [PATCH v1 net-next 01/15] iov_iter: Skip copy in memcpy_to_page if src==dst

2020-12-08 Thread Boris Pismenny
On 08/12/2020 2:39, David Ahern wrote: > On 12/7/20 2:06 PM, Boris Pismenny wrote: >> When using direct data placement the NIC writes some of the payload >> directly to the destination buffer, and constructs the SKB such that it >> points to this data. As a result, the skb_copy datagram_iter call

Re: [PATCH v1 net-next 01/15] iov_iter: Skip copy in memcpy_to_page if src==dst

2020-12-07 Thread David Ahern
On 12/7/20 2:06 PM, Boris Pismenny wrote: > When using direct data placement the NIC writes some of the payload > directly to the destination buffer, and constructs the SKB such that it > points to this data. As a result, the skb_copy datagram_iter call will > attempt to copy data when it is not ne

[PATCH v1 net-next 01/15] iov_iter: Skip copy in memcpy_to_page if src==dst

2020-12-07 Thread Boris Pismenny
When using direct data placement the NIC writes some of the payload directly to the destination buffer, and constructs the SKB such that it points to this data. As a result, the skb_copy datagram_iter call will attempt to copy data when it is not necessary. This patch adds a check to avoid this co