Re: [PATCH v1 net-next 00/15] nvme-tcp receive offloads

2021-01-14 Thread Sagi Grimberg
Hey Boris, sorry for some delays on my end... I saw some long discussions on this set with David, what is the status here? The main purpose of this series is to address these. I'll take some more look into the patches, but if you addressed the feedback from the last iteration I don't expe

Re: [PATCH v1 net-next 00/15] nvme-tcp receive offloads

2021-01-14 Thread Boris Pismenny
On 14/01/2021 6:47, David Ahern wrote: > On 1/13/21 6:27 PM, Sagi Grimberg wrote: >>> Changes since RFC v1: >>> = >>> * Split mlx5 driver patches to several commits >>> * Fix nvme-tcp handling of recovery flows. In particular, move queue >>> offlaod >>>   

Re: [PATCH v1 net-next 00/15] nvme-tcp receive offloads

2021-01-14 Thread Boris Pismenny
On 14/01/2021 3:27, Sagi Grimberg wrote: > Hey Boris, sorry for some delays on my end... > > I saw some long discussions on this set with David, what is > the status here? > The main purpose of this series is to address these. > I'll take some more look into the patches, but if you > addressed

Re: [PATCH v1 net-next 00/15] nvme-tcp receive offloads

2021-01-13 Thread David Ahern
On 1/13/21 6:27 PM, Sagi Grimberg wrote: >> Changes since RFC v1: >> = >> * Split mlx5 driver patches to several commits >> * Fix nvme-tcp handling of recovery flows. In particular, move queue >> offlaod >>    init/teardown to the start/stop functions. > > I

Re: [PATCH v1 net-next 00/15] nvme-tcp receive offloads

2021-01-13 Thread Sagi Grimberg
Hey Boris, sorry for some delays on my end... I saw some long discussions on this set with David, what is the status here? I'll take some more look into the patches, but if you addressed the feedback from the last iteration I don't expect major issues with this patch set (at least from nvme-tcp

[PATCH v1 net-next 00/15] nvme-tcp receive offloads

2020-12-07 Thread Boris Pismenny
This series adds support for nvme-tcp receive offloads which do not mandate the offload of the network stack to the device. Instead, these work together with TCP to offload: 1. copy from SKB to the block layer buffers 2. CRC verification for received PDU The series implements these as a generic of