Re: [PATCH v1 4/8] net: dsa: hellcreek: Add support for hardware timestamping

2020-07-13 Thread Richard Cochran
On Mon, Jul 13, 2020 at 05:12:17PM +0300, Vladimir Oltean wrote: > On Mon, Jul 13, 2020 at 07:01:12AM -0700, Richard Cochran wrote: > > I don't think it makes sense for DSA drivers to set this bit, as it > > serves no purpose in the DSA context. > > > > For whom does this bit serve a purpose, tho

Re: [PATCH v1 4/8] net: dsa: hellcreek: Add support for hardware timestamping

2020-07-13 Thread Vladimir Oltean
On Mon, Jul 13, 2020 at 07:01:12AM -0700, Richard Cochran wrote: > On Mon, Jul 13, 2020 at 12:57:34PM +0200, Kurt Kanzenbach wrote: > > > I would like to get some clarification on whether "SKBTX_IN_PROGRESS" > > > should be set in shtx->tx_flags or not. On one hand, it's asking for > > > trouble, o

Re: [PATCH v1 4/8] net: dsa: hellcreek: Add support for hardware timestamping

2020-07-13 Thread Richard Cochran
On Mon, Jul 13, 2020 at 12:57:34PM +0200, Kurt Kanzenbach wrote: > Hi Vladimir, > > On Mon Jul 13 2020, Vladimir Oltean wrote: > >> +/* Get a pointer to the PTP header in this skb */ > >> +static u8 *parse_ptp_header(struct sk_buff *skb, unsigned int type) > > > > Maybe this and the function from

Re: [PATCH v1 4/8] net: dsa: hellcreek: Add support for hardware timestamping

2020-07-13 Thread Kurt Kanzenbach
Hi Vladimir, On Mon Jul 13 2020, Vladimir Oltean wrote: > Hi Kurt, > > On Fri, Jul 10, 2020 at 01:36:07PM +0200, Kurt Kanzenbach wrote: >> From: Kamil Alkhouri >> >> The switch has the ability to take hardware generated time stamps per port >> for >> PTPv2 event messages in Rx and Tx direction.

Re: [PATCH v1 4/8] net: dsa: hellcreek: Add support for hardware timestamping

2020-07-13 Thread Vladimir Oltean
Hi Kurt, On Fri, Jul 10, 2020 at 01:36:07PM +0200, Kurt Kanzenbach wrote: > From: Kamil Alkhouri > > The switch has the ability to take hardware generated time stamps per port for > PTPv2 event messages in Rx and Tx direction. That is useful for achieving > needed > time synchronization precisi

Re: [PATCH v1 4/8] net: dsa: hellcreek: Add support for hardware timestamping

2020-07-12 Thread Kurt Kanzenbach
On Sat Jul 11 2020, Richard Cochran wrote: > On Fri, Jul 10, 2020 at 01:36:07PM +0200, Kurt Kanzenbach wrote: >> +static void hellcreek_get_rxts(struct hellcreek *hellcreek, >> + struct hellcreek_port_hwtstamp *ps, >> + struct sk_buff *skb, struct

Re: [PATCH v1 4/8] net: dsa: hellcreek: Add support for hardware timestamping

2020-07-11 Thread Richard Cochran
On Fri, Jul 10, 2020 at 01:36:07PM +0200, Kurt Kanzenbach wrote: > +static void hellcreek_get_rxts(struct hellcreek *hellcreek, > +struct hellcreek_port_hwtstamp *ps, > +struct sk_buff *skb, struct sk_buff_head *rxq, > +

[PATCH v1 4/8] net: dsa: hellcreek: Add support for hardware timestamping

2020-07-10 Thread Kurt Kanzenbach
From: Kamil Alkhouri The switch has the ability to take hardware generated time stamps per port for PTPv2 event messages in Rx and Tx direction. That is useful for achieving needed time synchronization precision for TSN devices/switches. So add support for it. There are two directions: * RX