Re: [PATCH stable 3.10-3.16] tcp: Fix crash in TCP Fast Open

2015-04-17 Thread Greg KH
On Wed, Apr 15, 2015 at 07:00:32PM +0100, Ben Hutchings wrote: > Commit 355a901e6cf1 ("tcp: make connect() mem charging friendly") > changed tcp_send_syn_data() to perform an open-coded copy of the 'syn' > skb rather than using skb_copy_expand(). > > The open-coded copy does not cover the skb_shar

Re: [PATCH stable 3.10-3.16] tcp: Fix crash in TCP Fast Open

2015-04-16 Thread Luis Henriques
On Wed, Apr 15, 2015 at 07:00:32PM +0100, Ben Hutchings wrote: > Commit 355a901e6cf1 ("tcp: make connect() mem charging friendly") > changed tcp_send_syn_data() to perform an open-coded copy of the 'syn' > skb rather than using skb_copy_expand(). > > The open-coded copy does not cover the skb_shar

Re: [PATCH stable 3.10-3.16] tcp: Fix crash in TCP Fast Open

2015-04-15 Thread David Miller
From: Eric Dumazet Date: Wed, 15 Apr 2015 11:22:44 -0700 > On Wed, 2015-04-15 at 19:00 +0100, Ben Hutchings wrote: >> Commit 355a901e6cf1 ("tcp: make connect() mem charging friendly") >> changed tcp_send_syn_data() to perform an open-coded copy of the 'syn' >> skb rather than using skb_copy_expan

Re: [PATCH stable 3.10-3.16] tcp: Fix crash in TCP Fast Open

2015-04-15 Thread Eric Dumazet
On Wed, 2015-04-15 at 19:00 +0100, Ben Hutchings wrote: > Commit 355a901e6cf1 ("tcp: make connect() mem charging friendly") > changed tcp_send_syn_data() to perform an open-coded copy of the 'syn' > skb rather than using skb_copy_expand(). > > The open-coded copy does not cover the skb_shared_info

[PATCH stable 3.10-3.16] tcp: Fix crash in TCP Fast Open

2015-04-15 Thread Ben Hutchings
Commit 355a901e6cf1 ("tcp: make connect() mem charging friendly") changed tcp_send_syn_data() to perform an open-coded copy of the 'syn' skb rather than using skb_copy_expand(). The open-coded copy does not cover the skb_shared_info::gso_segs field, so in the new skb it is left set to 0. When thi