Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2021-02-02 Thread Willem de Bruijn
On Tue, Feb 2, 2021 at 6:06 PM Michael S. Tsirkin wrote: > > On Tue, Feb 02, 2021 at 05:17:13PM -0500, Willem de Bruijn wrote: > > On Tue, Feb 2, 2021 at 9:08 AM Michael S. Tsirkin wrote: > > > > > > On Mon, Dec 28, 2020 at 11:22:32AM -0500, Willem de Bruijn wrote: > > > > From: Willem de Bruijn

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2021-02-02 Thread Michael S. Tsirkin
On Tue, Feb 02, 2021 at 05:17:13PM -0500, Willem de Bruijn wrote: > On Tue, Feb 2, 2021 at 9:08 AM Michael S. Tsirkin wrote: > > > > On Mon, Dec 28, 2020 at 11:22:32AM -0500, Willem de Bruijn wrote: > > > From: Willem de Bruijn > > > > > > Add optional PTP hardware timestamp offload for virtio-ne

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2021-02-02 Thread Willem de Bruijn
On Tue, Feb 2, 2021 at 9:08 AM Michael S. Tsirkin wrote: > > On Mon, Dec 28, 2020 at 11:22:32AM -0500, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > Add optional PTP hardware timestamp offload for virtio-net. > > > > Accurate RTT measurement requires timestamps close to the wire. > >

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2021-02-02 Thread Michael S. Tsirkin
On Mon, Dec 28, 2020 at 11:22:32AM -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > Add optional PTP hardware timestamp offload for virtio-net. > > Accurate RTT measurement requires timestamps close to the wire. > Introduce virtio feature VIRTIO_NET_F_RX_TSTAMP. If negotiated, the > v

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2021-02-02 Thread kernel test robot
Hi Willem, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ipvs/master] [also build test WARNING on linus/master v5.11-rc6 next-20210125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2020-12-30 Thread Richard Cochran
On Mon, Dec 28, 2020 at 07:57:20PM -0500, Willem de Bruijn wrote: > There is a well understood method for synchronizing guest and host > clock in KVM using ptp_kvm. For virtual environments without NIC > hardware offload, the when host timestamps in software, this suffices. > > Syncing host with N

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2020-12-30 Thread Jason Wang
On 2020/12/29 上午8:57, Willem de Bruijn wrote: On Mon, Dec 28, 2020 at 5:59 PM Jakub Kicinski wrote: On Mon, 28 Dec 2020 11:22:32 -0500 Willem de Bruijn wrote: From: Willem de Bruijn Add optional PTP hardware timestamp offload for virtio-net. Accurate RTT measurement requires timestamps cl

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2020-12-30 Thread Jason Wang
On 2020/12/29 下午10:20, Willem de Bruijn wrote: On Tue, Dec 29, 2020 at 4:23 AM Jason Wang wrote: - Original Message - On Mon, Dec 28, 2020 at 7:55 PM Michael S. Tsirkin wrote: On Mon, Dec 28, 2020 at 02:30:31PM -0500, Willem de Bruijn wrote: On Mon, Dec 28, 2020 at 12:29 PM Mich

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2020-12-29 Thread Willem de Bruijn
On Tue, Dec 29, 2020 at 4:23 AM Jason Wang wrote: > > > > - Original Message - > > On Mon, Dec 28, 2020 at 7:55 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Dec 28, 2020 at 02:30:31PM -0500, Willem de Bruijn wrote: > > > > On Mon, Dec 28, 2020 at 12:29 PM Michael S. Tsirkin > > > > w

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2020-12-29 Thread Jason Wang
- Original Message - > On Mon, Dec 28, 2020 at 7:55 PM Michael S. Tsirkin wrote: > > > > On Mon, Dec 28, 2020 at 02:30:31PM -0500, Willem de Bruijn wrote: > > > On Mon, Dec 28, 2020 at 12:29 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Dec 28, 2020 at 11:22:32AM -0500, Wi

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2020-12-28 Thread Willem de Bruijn
On Mon, Dec 28, 2020 at 7:55 PM Michael S. Tsirkin wrote: > > On Mon, Dec 28, 2020 at 02:30:31PM -0500, Willem de Bruijn wrote: > > On Mon, Dec 28, 2020 at 12:29 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Dec 28, 2020 at 11:22:32AM -0500, Willem de Bruijn wrote: > > > > From: Willem de Brui

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2020-12-28 Thread Willem de Bruijn
On Mon, Dec 28, 2020 at 5:59 PM Jakub Kicinski wrote: > > On Mon, 28 Dec 2020 11:22:32 -0500 Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > Add optional PTP hardware timestamp offload for virtio-net. > > > > Accurate RTT measurement requires timestamps close to the wire. > > Introduce

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2020-12-28 Thread Willem de Bruijn
On Mon, Dec 28, 2020 at 12:29 PM Michael S. Tsirkin wrote: > > On Mon, Dec 28, 2020 at 11:22:32AM -0500, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > Add optional PTP hardware timestamp offload for virtio-net. > > > > Accurate RTT measurement requires timestamps close to the wire. >

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2020-12-28 Thread Michael S. Tsirkin
On Mon, Dec 28, 2020 at 02:30:31PM -0500, Willem de Bruijn wrote: > On Mon, Dec 28, 2020 at 12:29 PM Michael S. Tsirkin wrote: > > > > On Mon, Dec 28, 2020 at 11:22:32AM -0500, Willem de Bruijn wrote: > > > From: Willem de Bruijn > > > > > > Add optional PTP hardware timestamp offload for virtio-

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2020-12-28 Thread Jakub Kicinski
On Mon, 28 Dec 2020 11:22:32 -0500 Willem de Bruijn wrote: > From: Willem de Bruijn > > Add optional PTP hardware timestamp offload for virtio-net. > > Accurate RTT measurement requires timestamps close to the wire. > Introduce virtio feature VIRTIO_NET_F_RX_TSTAMP. If negotiated, the > virtio-n

Re: [PATCH rfc 2/3] virtio-net: support receive timestamp

2020-12-28 Thread Michael S. Tsirkin
On Mon, Dec 28, 2020 at 11:22:32AM -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > Add optional PTP hardware timestamp offload for virtio-net. > > Accurate RTT measurement requires timestamps close to the wire. > Introduce virtio feature VIRTIO_NET_F_RX_TSTAMP. If negotiated, the > v

[PATCH rfc 2/3] virtio-net: support receive timestamp

2020-12-28 Thread Willem de Bruijn
From: Willem de Bruijn Add optional PTP hardware timestamp offload for virtio-net. Accurate RTT measurement requires timestamps close to the wire. Introduce virtio feature VIRTIO_NET_F_RX_TSTAMP. If negotiated, the virtio-net header is expanded with room for a timestamp. A host may pass receive