Re: [PATCH resend] Fix a lock problem in generic phy code

On Mon, Sep 10, 2007 at 08:45:50PM +0200, Hans-Jürgen Koch wrote: > > > Could you please audit all instances of physdev->lock and add > > _bh where necessary? I can see that at least phys_stop also > > needs the _bh. > > I think the patch does all that's necessary. At least, there're no error > m

Re: [PATCH resend] Fix a lock problem in generic phy code

Am Montag 10 September 2007 schrieb Herbert Xu: > Hans-J??rgen Koch <[EMAIL PROTECTED]> wrote: > > The following patch fixes it. Tested on an AT91SAM9263-EK board, kernel > > 2.6.23-rc4 and -rc3-mm1. > > Could you please audit all instances of physdev->lock and add > _bh where necessary? I can see

Re: [PATCH resend] Fix a lock problem in generic phy code

Hans-J??rgen Koch <[EMAIL PROTECTED]> wrote: > > The following patch fixes it. Tested on an AT91SAM9263-EK board, kernel > 2.6.23-rc4 and -rc3-mm1. Could you please audit all instances of physdev->lock and add _bh where necessary? I can see that at least phys_stop also needs the _bh. We should

[PATCH resend] Fix a lock problem in generic phy code

I already sent this patch on August, 31. I never got an answer, so here it is again. Lock debugging finds a problem in phy.c and phy_device.c: [    3.42] = [    3.42] [ INFO: inconsistent lock state ] [    3.42] 2.6.23-rc3-mm1 #21 [    3.42] --